From owner-freebsd-stable@FreeBSD.ORG Tue Mar 8 09:19:35 2011 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E91E31065673 for ; Tue, 8 Mar 2011 09:19:35 +0000 (UTC) (envelope-from jhellenthal@gmail.com) Received: from mail-iy0-f182.google.com (mail-iy0-f182.google.com [209.85.210.182]) by mx1.freebsd.org (Postfix) with ESMTP id A16D88FC1B for ; Tue, 8 Mar 2011 09:19:35 +0000 (UTC) Received: by iyj12 with SMTP id 12so5483473iyj.13 for ; Tue, 08 Mar 2011 01:19:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:sender:date:from:to:subject:in-reply-to :message-id:references:user-agent:x-openpgp-key-id :x-openpgp-key-fingerprint:mime-version:content-type; bh=Vo0VxuDXepakY4zkzJcXNk3GpwCy6RYAugBOERqwfBc=; b=fRmytyLL9x5+us8pyLIPWsID//XG06FC07uXFAq5GpHg9XfZDhDeVVGFjBSHGTD1Kn F9B1EBpn5cvA7cJHAlKfuag7BZrePS7uNnNOxS3keIFHoKsXc7M6tqB4iBa3eeAJnRpV cGDj6fFbjvkxF5jrah7+9sTXC4zGdVSxKMeRw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:date:from:to:subject:in-reply-to:message-id:references :user-agent:x-openpgp-key-id:x-openpgp-key-fingerprint:mime-version :content-type; b=w1n++Gfmd4TqsdgWHWldgU2A+ptz5etWiwnOFIzKtONGku1bMOjHmrllphN5lTu3Gz zTNxWd6FDTOOAFRr2PMfZes7YWnkmUY95aXO0YLNaCLmBJ9dPis8KuWdl79d3T9UQfpx 0m8C5fol6YgoGbLzH6RANEYKJxTUz9Y9dZspY= Received: by 10.43.65.134 with SMTP id xm6mr6093002icb.313.1299575974970; Tue, 08 Mar 2011 01:19:34 -0800 (PST) Received: from disbatch.dataix.local (adsl-99-181-148-141.dsl.klmzmi.sbcglobal.net [99.181.148.141]) by mx.google.com with ESMTPS id d10sm476242ibb.0.2011.03.08.01.19.32 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 08 Mar 2011 01:19:33 -0800 (PST) Sender: "J. Hellenthal" Date: Tue, 8 Mar 2011 04:18:41 -0500 From: "J. Hellenthal" To: FreeBSD Stable In-Reply-To: Message-ID: References: User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) X-OpenPGP-Key-Id: 0x89D8547E X-OpenPGP-Key-Fingerprint: 85EF E26B 07BB 3777 76BE B12A 9057 8789 89D8 547E MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="80310268-219105719-1299575973=:58425" Subject: Re: sys/x86/isa/clock.c:189: undefined reference to `cyclic_clock_func' X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Mar 2011 09:19:36 -0000 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --80310268-219105719-1299575973=:58425 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Tue, 8 Mar 2011 03:29, jhell@ wrote: > > Hello Stable@, > > Compiling a kernel on stable/8 with DTrace support is failing with the above > subject line upon linking kernel.debug. > > The text leading up to this is: > ... > ctfconvert -L VERSION -g vers.o > linking kernel.debug > clock.o(.text+0x84c): In function `clkintr': > /usr/src/sys/x86/isa/clock.c:189: undefined reference to `cyclic_clock_func' > > And upon inspection of clock.c: > #ifdef KDTRACE_HOOKS > #include > #endif > > And in clkintr(): > #ifdef KDTRACE_HOOKS > /* > * If the DTrace hooks are configured and a callback function > * has been registered, then call it to process the high speed > * timers. > */ > int cpu = PCPU_GET(cpuid); > if (cyclic_clock_func[cpu] != NULL) > (*cyclic_clock_func[cpu])(frame); > #endif > > > It seems for some odd reason that is being forgotten when > it comes time for linking ? What is going on here ? > > Id like to just remove the ifdef's for KDTRACE_HOOKS just to get the build to > finish but in the case that I want to build another kernel without dtrace I > would have to add them back. Anyone have a better fitting solution to this ? > > Would it be just as good to re-ifdef this to ?WITH_CTF? instead. > > Anyway... this is latest code from stable/8 on i386. And yes options > KDTRACE_HOOKS is in the kernel config. > > And the command that caused all this: > ( make kernel WITH_CTF=1 ) > In light of this I decided to just remove the effected section of clock.c and move forward as this part of the kernel with DTrace is not what I am looking into. Attached is a small patch that removes it in case someone else comes across the same thing and needs a quick workaround. - -- Regards, J. Hellenthal (0x89D8547E) JJH48-ARIN -----BEGIN PGP SIGNATURE----- Comment: THIS SOFTWARE AND/OR CONTENTS IS PROVIDED BY THE AUTHOR ``AS IS'' AND Comment: ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE Comment: IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR Comment: PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY Comment: DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL Comment: DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS Comment: OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) Comment: HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, Comment: STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING Comment: IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE Comment: POSSIBILITY OF SUCH DAMAGE. iQEcBAEBAgAGBQJNdfSCAAoJEJBXh4mJ2FR+K18H/A1KD0Ki1GR696dCvn2iJByH ym2nrsREjdVzFS2P7tW5PO0fmIc8eiFvqimeKHjexDS9JUH+3ybJ2ccF8JqHrR50 G/lNluptzLibPsqQY3+l/EsOUe//8NZUrUYV0ymOGfMsO5v49fBIfSKAT3JBFmY7 nq8wXMP5ncP8cjGdT6abSryIHmXVxY+E2R2DUOyfmbwZ+J/8fjfNEqxZta+Vc2Bv N2BJlEW1eJQBHrq2YuEM3iMBGqRkYywaG7hAWnJXXGUf+/8A/B3SgE1zLBlyCbfB osUjJE/AA7TtBawG6b5V10GCBSMxLaFdhaEzzyd4MtrRPnhuFWsjnPi4ACqnrhc= =3a8e -----END PGP SIGNATURE----- --80310268-219105719-1299575973=:58425 Content-Type: TEXT/PLAIN; charset=US-ASCII; name=clock-dtrace-removal.patch Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename=clock-dtrace-removal.patch Y2hhbmdlc2V0OiAgIDk0Nzo2ZGM4ZGU3Yjk3MzUNCmJyYW5jaDogICAgICBE YXRhSVgNCnRhZzogICAgICAgICB0aXANCnVzZXI6ICAgICAgICBKLiBIZWxs ZW50aGFsIDxqaGVsbEBEYXRhSVgubmV0Pg0KZGF0ZTogICAgICAgIFR1ZSBN YXIgMDggMDM6NTY6MzQgMjAxMSAtMDUwMA0Kc3VtbWFyeTogICAgIGNsa2lu dHIgcmVtb3ZhbCBvZiBjeWNsaWNfY2xvY2tfZnVuYyBLRFRSQUNFX0hPT0tT DQoNCmRpZmYgLXIgYjhmNzM5MmRlYWY2IC1yIDZkYzhkZTdiOTczNSBzeXMv eDg2L2lzYS9jbG9jay5jDQotLS0gYS9zeXMveDg2L2lzYS9jbG9jay5jCU1v biBNYXIgMDcgMTM6MDY6NTAgMjAxMSAtMDUwMA0KKysrIGIvc3lzL3g4Ni9p c2EvY2xvY2suYwlUdWUgTWFyIDA4IDAzOjU2OjM0IDIwMTEgLTA1MDANCkBA IC0xNzksMTcgKzE3OSw2IEBADQogCUtBU1NFUlQodXNpbmdfbGFwaWNfdGlt ZXIgPT0gTEFQSUNfQ0xPQ0tfTk9ORSwNCiAJICAgICgiY2xrIGludGVycnVw dCBlbmFibGVkIHdpdGggbGFwaWMgdGltZXIiKSk7DQogDQotI2lmZGVmIEtE VFJBQ0VfSE9PS1MNCi0JLyoNCi0JICogSWYgdGhlIERUcmFjZSBob29rcyBh cmUgY29uZmlndXJlZCBhbmQgYSBjYWxsYmFjayBmdW5jdGlvbg0KLQkgKiBo YXMgYmVlbiByZWdpc3RlcmVkLCB0aGVuIGNhbGwgaXQgdG8gcHJvY2VzcyB0 aGUgaGlnaCBzcGVlZA0KLQkgKiB0aW1lcnMuDQotCSAqLw0KLQlpbnQgY3B1 ID0gUENQVV9HRVQoY3B1aWQpOw0KLQlpZiAoY3ljbGljX2Nsb2NrX2Z1bmNb Y3B1XSAhPSBOVUxMKQ0KLQkJKCpjeWNsaWNfY2xvY2tfZnVuY1tjcHVdKShm cmFtZSk7DQotI2VuZGlmDQotDQogCWlmICh1c2luZ19hdHJ0Y190aW1lcikg ew0KICNpZmRlZiBTTVANCiAJCWlmIChzbXBfc3RhcnRlZCkNCg0K --80310268-219105719-1299575973=:58425--