From owner-p4-projects@FreeBSD.ORG  Mon Jul 24 20:26:59 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 8D4DF16A4E2; Mon, 24 Jul 2006 20:26:59 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 3806216A4DF;
	Mon, 24 Jul 2006 20:26:59 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net
	[66.23.211.162])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 73FFF43D46;
	Mon, 24 Jul 2006 20:26:58 +0000 (GMT) (envelope-from jhb@freebsd.org)
Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1])
	(authenticated bits=0)
	by server.baldwin.cx (8.13.4/8.13.4) with ESMTP id k6OKQr3M028136;
	Mon, 24 Jul 2006 16:26:57 -0400 (EDT) (envelope-from jhb@freebsd.org)
From: John Baldwin <jhb@freebsd.org>
To: Scott Long <scottl@samsco.org>
Date: Mon, 24 Jul 2006 16:00:04 -0400
User-Agent: KMail/1.9.1
References: <200607221233.k6MCXjIL033391@repoman.freebsd.org>
	<44C279E9.9060002@samsco.org>
In-Reply-To: <44C279E9.9060002@samsco.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200607241600.05305.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by
	milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]);
	Mon, 24 Jul 2006 16:26:57 -0400 (EDT)
X-Virus-Scanned: ClamAV 0.87.1/1616/Mon Jul 24 13:49:29 2006 on
	server.baldwin.cx
X-Virus-Status: Clean
X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 
	autolearn=ham version=3.1.0
X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on server.baldwin.cx
Cc: Perforce Change Reviews <perforce@freebsd.org>,
	Paolo Pisati <piso@freebsd.org>
Subject: Re: PERFORCE change 102141 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Jul 2006 20:26:59 -0000

On Saturday 22 July 2006 15:18, Scott Long wrote:
> Paolo Pisati wrote:
> 
> > http://perforce.freebsd.org/chv.cgi?CH=102141
> > 
> > Change 102141 by piso@piso_longino on 2006/07/22 12:33:15
> > 
> > 	Use IF_FAST macro instead of directly checking flags,
> > 	and axe an INTR_FAST check in swi_add(): is it possible
> > 	for a software interrupt handler to have INTR_FAST defined?
> > 	did it make sense at all? 
> > 
> 
> An swi is an ithread by definition, so INTR_FAST makes no sense to
> it.

Hence the EINVAL. :)  Now that the flag no longer exists, the check can just 
be removed.

-- 
John Baldwin