From owner-cvs-src@FreeBSD.ORG Sun Aug 22 19:50:39 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A3C4616A4CF; Sun, 22 Aug 2004 19:50:39 +0000 (GMT) Received: from rwcrmhc11.comcast.net (rwcrmhc11.comcast.net [204.127.198.35]) by mx1.FreeBSD.org (Postfix) with ESMTP id 841C343D3F; Sun, 22 Aug 2004 19:50:39 +0000 (GMT) (envelope-from DougB@dougbarton.net) Received: from [192.168.0.4] (c-24-130-110-32.we.client2.attbi.com[24.130.110.32]) by comcast.net (rwcrmhc11) with ESMTP id <2004082219503801300r6lbje> (Authid: domain_name_tsar); Sun, 22 Aug 2004 19:50:39 +0000 Message-ID: <4128F90D.8080506@DougBarton.net> Date: Sun, 22 Aug 2004 12:50:37 -0700 From: Doug Barton User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.2) Gecko/20040811 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Colin Percival References: <200408161152.i7GBqMlq084661@repoman.freebsd.org> <6.1.0.6.1.20040816045454.02a34168@popserver.sfu.ca> In-Reply-To: <6.1.0.6.1.20040816045454.02a34168@popserver.sfu.ca> X-Enigmail-Version: 0.84.2.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: Colin Percival Subject: Re: cvs commit: src/etc services X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Aug 2004 19:50:39 -0000 Colin Percival wrote: > At 04:52 16/08/2004, Colin Percival wrote: > >>cperciva 2004-08-16 11:52:22 UTC >> Modified files: >> etc services >> Log: >> Add 3653/tcp and 3653/udp, since they were specifically requested. > > > As discussed earlier, I have another 6400 lines ready to > merge from IANA's list. Since some benchmarks have been > produced showing that adding that many new entries into > /etc/services could have a significant performance impact, > I'm going to wait until after 5-STABLE is branched, and > only commit these to 6-CURRENT. If/when the performance > impact becomes insignificant (due to the addition of a > lookup daemon, for example), I'll merge them into STABLE. Please don't commit these changes to 6-current without discussion on -arch, which I would like to be involved in. This topic has come up many times before (including a long time ago instigated by me) and the consensus has always been to add lines from the IANA table when they are specifically requested, IF they add value to a significant percentage of our userbase. I don't see any reason to change that philosophy with 6-current, and I'd like to see significant discussion as to why it's a value add to change the philosophy before any changes are made to the file. Also, I'd like to point out that many of the port numbers in the current IANA list are not related to active products, so adding them all would be a waste of time, and degrade performance for no good reason. Finally, the solution that has most often been discussed for improving the performance of getservbyname() and friends is a Berkeley db implementation similar to the way login.conf is done now. I'm not sure a lookup daemon is justified, and I'd like to see some discussion about this topic too. Thanks, Doug -- If you're never wrong, you're not trying hard enough