Date: Fri, 22 Aug 2003 09:50:07 -0700 (PDT) From: Colin Percival <colin.percival@wadham.ox.ac.uk> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/55869: [MAINTAINER UPDATE] security/freebsd-update Message-ID: <200308221650.h7MGo7fX082073@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/55869; it has been noted by GNATS.
From: Colin Percival <colin.percival@wadham.ox.ac.uk>
To: freebsd-gnats-submit@FreeBSD.org, cperciva@daemonology.net,
osa@FreeBSD.org
Cc:
Subject: Re: ports/55869: [MAINTAINER UPDATE] security/freebsd-update
Date: Fri, 22 Aug 2003 09:40:47 -0700
"Sergey A. Osokin" <osa@FreeBSD.org> wrote:
>On Sat, Sep 25, 2004 at 03:30:36PM -0000, Colin Percival wrote:
> > + WORKDIR?=${.CURDIR}/work
> > + MAILTO?=root
> > ++BSPATCH!=which bspatch || echo /usr/local/bin/bspatch
> ^^^^^^^^^^^^^^^^
> I think it must be ${LOCALBASE}/bin/bspatch, do you?
Only if LOCALBASE is defined in make.conf (which it isn't, at least on
my system). The makefile being patched there isn't part of the build
process for the freebsd-update port (ok, not much, at least); it's part of
the actual program. (I had a reason for this once. I don't any more, and
some day I'll replace that makefile with a much cleaner shell script, but I
don't want to mess with it right now.)
I suppose I could have used sed and made that a %%LOCALBASE%%, but if
someone doesn't have ${LOCALBASE}/bin in their path *and* they put
LOCALBASE somewhere other than /usr/local, I'm not especially inclined to
change things to suit them. Even for them, FreeBSD Update will still work;
it will just waste bandwidth by downloading complete modified files instead
of using the patches.
Colin Percival
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200308221650.h7MGo7fX082073>