From owner-cvs-all@FreeBSD.ORG Fri Apr 22 02:22:25 2005 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 13E8916A4CE; Fri, 22 Apr 2005 02:22:25 +0000 (GMT) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.FreeBSD.org (Postfix) with ESMTP id E9F3243D53; Fri, 22 Apr 2005 02:22:23 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.3/8.13.3) with ESMTP id j3M2MJnE012590; Fri, 22 Apr 2005 06:22:19 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.3/8.13.3/Submit) id j3M2MIWk012589; Fri, 22 Apr 2005 06:22:18 +0400 (MSD) (envelope-from yar) Date: Fri, 22 Apr 2005 06:22:18 +0400 From: Yar Tikhiy To: Doug Ambrisko Message-ID: <20050422022218.GA11340@comp.chem.msu.su> References: <20050421105337.GD69054@comp.chem.msu.su> <200504211413.j3LEDTPY007967@ambrisko.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200504211413.j3LEDTPY007967@ambrisko.com> User-Agent: Mutt/1.5.9i cc: Doug Ambrisko cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/ata ata-all.c ata-all.h ata-dma.c ata-pci.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Apr 2005 02:22:25 -0000 On Thu, Apr 21, 2005 at 07:13:28AM -0700, Doug Ambrisko wrote: > Yar Tikhiy writes: > | On Wed, Apr 20, 2005 at 11:51:32PM +0000, Doug Ambrisko wrote: > | > ambrisko 2005-04-20 23:51:32 UTC > | > > | > FreeBSD src repository > | > > | > Modified files: (Branch: RELENG_4) > | > sys/dev/ata ata-all.c ata-all.h ata-dma.c ata-pci.c > | > Log: > | > Add in Promise and Intel SATA support based on FreeBSD 5.X ATAng. > | > This gets the HW to work but not to deal with SATA errors. So if > | > the drive has a read error it will probably lock up. This is > | > a small subset of my patches that do deal with these errors and > | > other issues in FreeBSD and ata-raid. > | > > | > Sponsored by: IronPort Systems > | > > | > Revision Changes Path > | > 1.50.2.49 +168 -36 src/sys/dev/ata/ata-all.c > | > 1.26.2.15 +166 -13 src/sys/dev/ata/ata-all.h > | > 1.35.2.39 +95 -17 src/sys/dev/ata/ata-dma.c > | > 1.32.2.22 +164 -18 src/sys/dev/ata/ata-pci.c > | > | I myself was bitten by RELENG_4 ATA support lagging behind modern > | hardware, which made me move to RELENG_5 on some systems at last. > | However, isn't your change too big and possibly destabilizing for > | the conservative RELENG_4 branch? I'm judging by the number of > | changed lines only. And honestly, I'm having trouble understanding > | from the commit message whether your change introduces or corrects > | the bug in SATA error detection. > > It makes some Promise HW work that wouldn't probe at all. For the > Intel stuff adds device ID's. Most of the changed lines are a > mechanical type thing which is using the new indirection macros so > we can probe HW like that in the Promise cards. The core ATA code > didn't change. Addition code was required to make the Promise HW work. > > It is based on a subset of stuff at: > http://www.ambrisko.com/doug/ata/ > which has been running on lots of machines. This patchset which is > approaching 140k has lots of various panic (ata & FreeBSD) fixes and > enhanced SATA & ata-raid support that prevents systems from freezing, > crashing and automatic drive recovery in mirrors. I don't plan to be > merge all of that in, just the basic HW support so people can install. > > It looks like in ata mkIII there is better support of SATA & RAID stuff > going in so that looks encouraging. Thank you for the explanation! Now I see that the only issue about your change is that it will let some feeble folks avoid their destiny of running RELENG_5 or CURRENT on their cool brand-new production systems ;-) -- Yar