From owner-svn-ports-head@freebsd.org Thu May 31 19:03:23 2018 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 95CBEFC9A83 for ; Thu, 31 May 2018 19:03:23 +0000 (UTC) (envelope-from adamw@adamw.org) Received: from mail-yb0-x235.google.com (mail-yb0-x235.google.com [IPv6:2607:f8b0:4002:c09::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 378C3786F5 for ; Thu, 31 May 2018 19:03:23 +0000 (UTC) (envelope-from adamw@adamw.org) Received: by mail-yb0-x235.google.com with SMTP id i1-v6so7947867ybe.1 for ; Thu, 31 May 2018 12:03:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adamw-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CwVvgZn+BVXPt8dc8lR8WImp8BVevBhfWMt9LXZUsbA=; b=rIeIYCOZVJwu5HoBYJ4o59rtokEluvlh9DyrGIsRR2SHiogq6p1IKnoqUUElFtqrOn Tp/g5nCizH1WjWatfdbd4dFb6JImgsOS3AziJhBKlM1Ovi95a9tWsyCLxpYfcyTgOMzb IPuoKMANl5CN+yP4CvwHO36eFBZsJ5ktVlI3Tl6AUPRRVcoRyG0kBWelMWoBO8+1UIdk 1v/jHbOUZVtze2ElDzifGekGWlQHBKh2mpMkD0yjoE7pZVxgcWj/q1G8neihQ4FnEWSj TAOM2EUFvXTK/SUCe13eYDWT5dExFZTntbLa5N3E4YhuRhpVsl85GaIT/pX5MpN+W/JH qcAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CwVvgZn+BVXPt8dc8lR8WImp8BVevBhfWMt9LXZUsbA=; b=gYjon0bNfK+L5wxRRsFbDfD11VwTm1e85QlU+c/t/e5ctGYA3Oj9pRYYo2rOPjJJ8k 1l91ZhBrVJqIdheEgieyfFuMGvv/97+dOH2nBHTueNNFascMuYf1EiCC+Qw1Y1p9tfO/ QOvYcDJBcSclFlwhUTfAGyoNKUBy3CfwqpGMJpQsYOqFdfojEmDbVNJ17a6lSwYW5CM1 OHuTu9IvKsUSAoNs73hOuCbStIiuBU6pLhmWMovXbxCSYz9sFlhiUw+jv0/daBDJEobi KP9zgJF78XykgwKb52Opy1zwwDCTwRVvtvIRYdiVHRGlvq1ey+z8VurgeqQ1oR6CktFW 1P4Q== X-Gm-Message-State: ALKqPwfcmmsZbkovFske040aVNTG9ubXgt7UTqp5Em9qIds+U/dQuEsa x2h7GVLzJXChhgiOnoZFdOg0nQQu0nFDigSSU7r1DA== X-Google-Smtp-Source: ADUXVKL7piJaonpcY/7uCzfOwWJDU1/N1Rl6EHk87xyXAVxKcgx466R2znGwwNnoarasVQXqZOeQL8QMX07Jjcrbg+0= X-Received: by 2002:a25:2551:: with SMTP id l78-v6mr4489697ybl.140.1527793402516; Thu, 31 May 2018 12:03:22 -0700 (PDT) MIME-Version: 1.0 References: <201805301747.w4UHlULA089466@repo.freebsd.org> <20180530182307.amhg76hnhrn5rw7a@ogg.in.absolight.net> <1527789939.1527345.1392093808.29FB882C@webmail.messagingengine.com> In-Reply-To: <1527789939.1527345.1392093808.29FB882C@webmail.messagingengine.com> From: Adam Weinberger Date: Thu, 31 May 2018 13:03:06 -0600 Message-ID: Subject: Re: svn commit: r471139 - head/devel/libconfuse To: tobiaskortkamp@fastmail.com Cc: mat@freebsd.org, wg@freebsd.org, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 May 2018 19:03:23 -0000 On Thu, May 31, 2018 at 12:05 PM Tobias Kortkamp wrote: > > On Wed, May 30, 2018, at 20:23, Mathieu Arnold wrote: > > On Wed, May 30, 2018 at 05:47:30PM +0000, William Grzybowski wrote: > > > Author: wg > > > Date: Wed May 30 17:47:30 2018 > > > New Revision: 471139 > > > URL: https://svnweb.freebsd.org/changeset/ports/471139 > > > > > > Log: > > > devel/libconfuse: update to 3.2.1 > > > > > > PR: 227473 > > > Approved by: maintainer timeout > > > > > > Modified: > > > head/devel/libconfuse/Makefile > > > head/devel/libconfuse/distinfo > > > head/devel/libconfuse/pkg-plist > > > > > > Modified: head/devel/libconfuse/Makefile > > > ============================================================================== > > > --- head/devel/libconfuse/Makefile Wed May 30 17:22:12 2018 (r471138) > > > +++ head/devel/libconfuse/Makefile Wed May 30 17:47:30 2018 (r471139) > > > @@ -2,12 +2,14 @@ > > > # $FreeBSD$ > > > > > > PORTNAME= libconfuse > > > -PORTVERSION= 2.7 > > > -PORTREVISION= 2 > > > +DISTVERSION= 3.2.1 > > > CATEGORIES= devel > > > -MASTER_SITES= SAVANNAH/confuse > > > -DISTNAME= confuse-${PORTVERSION} > > > > > > > The whole USE_GITHUB block happens way too early, see > > https://www.freebsd.org/doc/en/books/porters-handbook/porting-order.html > > > > > +USE_GITHUB= yes > > > +GH_ACCOUNT= martinh > > > +GH_PROJECT= libconfuse > > > > This is the default, please remove. > > > > > +GH_TAGNAME= v3.2.1 > > > > Replace in favor of DISTVERSIONPREFIX=v > > Wouldn't it be even better to continue using the release tarballs with > pregenerated autoconf files that upstream provides? > > https://github.com/martinh/libconfuse/releases/download/v3.2.1/confuse-3.2.1.tar.gz > I'm not trying to pick on you, wg, but folks, please run portlint before committing. I know it can produce false positives, but when it produces 6 fatal errors and 8 warnings, it's worth listening to before committing. # Adam -- Adam Weinberger adamw@adamw.org https://www.adamw.org