From owner-cvs-share Thu Oct 5 07:57:54 1995 Return-Path: owner-cvs-share Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id HAA10678 for cvs-share-outgoing; Thu, 5 Oct 1995 07:57:54 -0700 Received: from sovcom.kiae.su (sovcom.kiae.su [144.206.136.1]) by freefall.freebsd.org (8.6.12/8.6.6) with SMTP id HAA10651 ; Thu, 5 Oct 1995 07:56:47 -0700 Received: by sovcom.kiae.su id AA29627 (5.65.kiae-1 ); Thu, 5 Oct 1995 17:40:55 +0300 Received: by sovcom.KIAE.su (UUMAIL/2.0); Thu, 5 Oct 95 17:40:54 +0300 Received: (from ache@localhost) by ache.dialup.demos.ru (8.6.11/8.6.9) id RAA00896; Thu, 5 Oct 1995 17:30:25 +0300 To: ache@freefall.freebsd.org, Satoshi Asami Cc: CVS-commiters@freefall.freebsd.org, cvs-share@freefall.freebsd.org References: <199510050429.VAA07365@silvia.HIP.Berkeley.EDU> In-Reply-To: <199510050429.VAA07365@silvia.HIP.Berkeley.EDU>; from Satoshi Asami at Wed, 4 Oct 1995 21:29:46 -0700 Message-Id: Organization: Olahm Ha-Yetzirah Date: Thu, 5 Oct 1995 17:30:24 +0300 (MSK) X-Mailer: Mail/@ [v2.40 FreeBSD] From: =?KOI8-R?Q?=E1=CE=C4=D2=C5=CA_=FE=C5=D2=CE=CF=D7?= (aka Andrey A. Chernov, Black Mage) X-Class: Fast Subject: Re: cvs commit: src/share/mk bsd.port.mk Lines: 49 Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Length: 1838 Sender: owner-cvs-share@FreeBSD.org Precedence: bulk In message <199510050429.VAA07365@silvia.HIP.Berkeley.EDU> Satoshi Asami writes: > * Modified: share/mk bsd.port.mk > * Log: > * Add CONFIGURE_ENV: pass this environment to configure script. > * Allows pre-set some variables to eliminate wrong tests >I've got only six questions about this change: >(1) Which port required this? Currently ncftp2 (it _always_ require it, not with latest update only, but I don't pay much attention to it). It always can't find getmaxyx which is really present. Fixing it at configure script level (submitting patch back to author assumed) involved to complex and deep work, I don't want to spent time for it. There was several other ports which I have problems too (I don't remebrer right now, grep usage needed) which I forced to hack configure scripts directly, now I can do it without source modifications. >(2) Couldn't it have been done as a special target in the port > Makefile instead of in a file that affects all the other ports? It can't be done as special target. It not affects other ports if you don't set CONFIGURE_ENV variable directly. >(3) If not, should this go int 2.1R? It will be nice, if goes. >(4) If yes, this is the list of ports I already built with the "old" > bsd.port.mk, can you please go check and see if they will all > build and package fine with the modified bsd.port.mk? They all build with new bsd.port.mk. It not affects any ports. If you simple look at my change in bsd.port.mk (2 lines affected), you'll have less questions about it. -- Andrey A. Chernov : And I rest so composedly, /Now, in my bed, ache@astral.msk.su : That any beholder /Might fancy me dead - FidoNet: 2:5020/230.3 : Might start at beholding me, /Thinking me dead. RELCOM Team,FreeBSD Team : E.A.Poe From "For Annie" 1849