Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 19 Nov 2000 22:34:03 +0200
From:      Mark Murray <mark@grondar.za>
To:        Kris Kennaway <kris@FreeBSD.ORG>
Cc:        audit@FreeBSD.ORG
Subject:   Re: bootpd patch 
Message-ID:  <200011192034.eAJKY4J16116@gratis.grondar.za>
In-Reply-To: <20001119032345.A91835@citusc17.usc.edu> ; from Kris Kennaway <kris@FreeBSD.ORG>  "Sun, 19 Nov 2000 03:23:45 PST."
References:  <20001119032345.A91835@citusc17.usc.edu> 

next in thread | previous in thread | raw e-mail | index | archive | help
> The following patches are taken from OpenBSD. Reviews, anyone?

Looks good, except the sizeof(...) have a degree of repetitiveness about
them (function/macro candidate), and the use of constants instead of
#defines in array sizes.

Apart from that, OK.

M
--
Mark Murray
Join the anti-SPAM movement: http://www.cauce.org


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200011192034.eAJKY4J16116>