From owner-freebsd-fs@FreeBSD.ORG  Wed Nov 27 16:18:57 2013
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
Delivered-To: freebsd-fs@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id F0301CB8;
 Wed, 27 Nov 2013 16:18:56 +0000 (UTC)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
 by mx1.freebsd.org (Postfix) with ESMTP id 7D1382971;
 Wed, 27 Nov 2013 16:18:55 +0000 (UTC)
Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua
 [212.40.38.100])
 by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id SAA08413;
 Wed, 27 Nov 2013 18:18:47 +0200 (EET) (envelope-from avg@FreeBSD.org)
Received: from localhost ([127.0.0.1])
 by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD))
 id 1Vlhp8-0005kS-T4; Wed, 27 Nov 2013 18:18:46 +0200
Message-ID: <52961B2E.1080602@FreeBSD.org>
Date: Wed, 27 Nov 2013 18:17:50 +0200
From: Andriy Gapon <avg@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:24.0) Gecko/20100101 Thunderbird/24.1.0
MIME-Version: 1.0
To: src-committers@FreeBSD.org, svn-src-all@FreeBSD.org,
 svn-src-head@FreeBSD.org,
 FreeBSD Current <freebsd-current@FreeBSD.org>, freebsd-fs@FreeBSD.org
Subject: [HEADSUP!!!] do not upgrade to or past r258632 if you use ZFS + TRIM
References: <201311260957.rAQ9vF6d004168@svn.freebsd.org>
In-Reply-To: <201311260957.rAQ9vF6d004168@svn.freebsd.org>
X-Enigmail-Version: 1.6
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.16
Precedence: list
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-fs>,
 <mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs/>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
 <mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 27 Nov 2013 16:18:57 -0000

on 26/11/2013 11:57 Andriy Gapon said the following:
> Author: avg
> Date: Tue Nov 26 09:57:14 2013
> New Revision: 258632
> URL: http://svnweb.freebsd.org/changeset/base/258632
> 
> Log:
>   MFV r255255: 4045 zfs write throttle & i/o scheduler performance work
>   
>   illumos/illumos-gate@69962b5647e4a8b9b14998733b765925381b727e
>   
>   Please note the following changes:
>   - zio_ioctl has lost its priority parameter and now TRIM is executed
>     with 'now' priority
>   - some knobs are gone and some new knobs are added; not all of them are
>     exposed as tunables / sysctls yet
>   
>   MFC after:	10 days
>   Sponsored by:	HybridCluster [merge]

I think that I've introduced a very serious bug when merging this change.
Please do not upgrade to this revision if you use ZFS with SSDs and have TRIM
support enabled.

If you have already upgraded, please disable TRIM support ASAP and roll back to
a previous version of kernel and then check integrity of your pools.

-- 
Andriy Gapon