From owner-svn-ports-head@FreeBSD.ORG Fri Aug 2 11:30:12 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id DA1A0B87; Fri, 2 Aug 2013 11:30:12 +0000 (UTC) (envelope-from bsam@passap.ru) Received: from forward3l.mail.yandex.net (forward3l.mail.yandex.net [IPv6:2a02:6b8:0:1819::3]) by mx1.freebsd.org (Postfix) with ESMTP id 9ABDC2273; Fri, 2 Aug 2013 11:30:12 +0000 (UTC) Received: from smtp11.mail.yandex.net (smtp11.mail.yandex.net [95.108.130.67]) by forward3l.mail.yandex.net (Yandex) with ESMTP id E98231500CAC; Fri, 2 Aug 2013 15:30:10 +0400 (MSK) Received: from smtp11.mail.yandex.net (localhost [127.0.0.1]) by smtp11.mail.yandex.net (Yandex) with ESMTP id 7824E7E02F5; Fri, 2 Aug 2013 15:30:10 +0400 (MSK) Received: from 87.249.28.58.tel.ru (87.249.28.58.tel.ru [87.249.28.58]) by smtp11.mail.yandex.net (nwsmtp/Yandex) with ESMTP id QqtharNeHR-UAUKjWSX; Fri, 2 Aug 2013 15:30:10 +0400 Message-ID: <51FB9841.8080209@passap.ru> Date: Fri, 02 Aug 2013 15:30:09 +0400 From: Boris Samorodov User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130707 Thunderbird/17.0.7 MIME-Version: 1.0 To: Alexey Dokuchaev Subject: Re: svn commit: r324154 - head/astro/aa References: <201308020833.r728X9Xs050646@svn.freebsd.org> <51FB8FFD.2030806@passap.ru> <20130802110612.GA65951@FreeBSD.org> In-Reply-To: <20130802110612.GA65951@FreeBSD.org> Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Fri, 02 Aug 2013 11:48:33 +0000 Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Aug 2013 11:30:12 -0000 02.08.2013 15:06, Alexey Dokuchaev ÐÉÛÅÔ: > On Fri, Aug 02, 2013 at 02:54:53PM +0400, Boris Samorodov wrote: >> 02.08.2013 12:33, Alexey Dokuchaev пишет: >>> New Revision: 324154 >>> URL: http://svnweb.freebsd.org/changeset/ports/324154 >>> >>> Log: >>> - Convert Makefile header to the new two-line form >>> - Remove 404'ing URL from MASTER_SITES >>> - Do not explicitly set EXTRACT_AFTER_ARGS, use NO_WRKSUBDIR instead >>> - Avoid patching makefile: pass correct values via MAKE_ARGS; this also >>> remove double whitespace before -Wall from the build logs (nice) >>> - NOPORTDOCS -> PORT_OPTIONS:MDOCS, get rid of .for loops, unmute the >>> installation commands, make pkg-message display consistent with package >>> - Reformat port description for better readability while here >> [...] >>> MAINTAINER= frank@dynamical-systems.org >> >> Hm, I thought that maintained ports should go though PRs... >> Am I wrong here? > > Normally yes. However: You know, I didn't try to offend you. Your commits are almost perfect and your comments are very helpful. > 1) these are the ports which have been failing for > a while on the build cluster, and no one stepped to fix it; 2) miwi@ asked > me if I can help to offload the pile of error logs, so I guess I can have > an informal blessing from portmgr@ side; I'd say that a line "Approved by: portmgr (miwi, implicit)" will clean up all possible questions for current and furure readers of commit/log. > 3) I try not to touch/change any > user-visible logic of the port; 4) I have several hundreds logs to read, > analyze, fix, test (several times on different CPU arches), and commit. > I know what I'm doing, Yes, I'm sure. It's not you but others (including me) that make me worry. So the main question which I try to get an answer is "What I as a committer may do and what I shouldn't". > I try my best to make sure my fixes are correct, I > have time to invest in ports now, and I don't see that being bureaucratic > is worth anything -- I emphasize -- in this particular case. > > That said, for some of these, I nonetheless ask for explicit approval, esp. > if maintainer hangs out on IRC. Thanks for making FreeBSD better. -- WBR, Boris Samorodov (bsam) FreeBSD Committer, http://www.FreeBSD.org The Power To Serve