Date: Tue, 8 Jan 2019 11:44:57 -0700 From: Sean Bruno <sbruno@freebsd.org> To: Tobias Kortkamp <tobik@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r489228 - in head/audio: clementine-player clementine-player/files libechonest Message-ID: <0a880448-8ef7-76ff-e531-929dbce9ccf3@freebsd.org> In-Reply-To: <b472df4d-574e-09f8-6212-687209d31bbc@freebsd.org> References: <201901032143.x03LhwZl017869@repo.freebsd.org> <20190103215421.GA13148@urd.tobik.me> <849c06ba-b298-2460-091b-0b3db52d8d16@freebsd.org> <20190103232315.GA10712@urd.tobik.me> <b472df4d-574e-09f8-6212-687209d31bbc@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ShuzWwyVKw5Cs3lDxPHdzYE7z9UF2sIPQ Content-Type: multipart/mixed; boundary="4xt8yImpwj1fMx0fi9qIC73wTssaMl3Zs"; protected-headers="v1" From: Sean Bruno <sbruno@freebsd.org> To: Tobias Kortkamp <tobik@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Message-ID: <0a880448-8ef7-76ff-e531-929dbce9ccf3@freebsd.org> Subject: Re: svn commit: r489228 - in head/audio: clementine-player clementine-player/files libechonest References: <201901032143.x03LhwZl017869@repo.freebsd.org> <20190103215421.GA13148@urd.tobik.me> <849c06ba-b298-2460-091b-0b3db52d8d16@freebsd.org> <20190103232315.GA10712@urd.tobik.me> <b472df4d-574e-09f8-6212-687209d31bbc@freebsd.org> In-Reply-To: <b472df4d-574e-09f8-6212-687209d31bbc@freebsd.org> --4xt8yImpwj1fMx0fi9qIC73wTssaMl3Zs Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 1/8/19 10:23 AM, Sean Bruno wrote: >=20 >=20 > On 1/3/19 4:23 PM, Tobias Kortkamp wrote: >>> >>> On 1/3/19 2:54 PM, Tobias Kortkamp wrote: >>>>> +USE_QT=3D buildtools \ >>>> Does clementine-player, a music player, really need qt5-buildtools >>>> at runtime or should this be buildtools_build instead? >>>> >>>>> + concurrent \ >>>>> + core \ >>>>> dbus \ >>>>> gui \ >>>>> imageformats \ >>>>> - qmake_build \ >>>>> linguist_build \ >>>>> - moc_build \ >>>>> network \ >>>>> opengl \ >>>>> - qtestlib \ >>>>> - rcc_build \ >>>>> + qmake_build \ >>>>> + testlib \ >>>> Same here. Does it really need qt5-testlib at runtime? >>>> >>> Probably not? >>> >>> sean >>> >> So I guess they are not needed at runtime. Will you change them >> to build dependencies? >=20 > Yeah, I'll look at it today. Thanks! >=20 > sean >=20 Something like this will solve this runtime/buildtime depend issue? Obviously, I'll buildtime/runtime test it before commit. Index: audio/clementine-player/Makefile =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- audio/clementine-player/Makefile (revision 489727) +++ audio/clementine-player/Makefile (working copy) @@ -41,7 +41,7 @@ USE_GL=3D gl glew glu USE_XORG=3D x11 -USE_QT=3D buildtools \ +USE_QT=3D buildtools_build \ concurrent \ core \ dbus \ @@ -51,7 +51,7 @@ network \ opengl \ qmake_build \ - testlib \ + testlib_build \ sql \ widgets \ x11extras \ --4xt8yImpwj1fMx0fi9qIC73wTssaMl3Zs-- --ShuzWwyVKw5Cs3lDxPHdzYE7z9UF2sIPQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEE6MTp+IA1BOHj9Lo0veT1/om1/LYFAlw076lfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEU4 QzRFOUY4ODAzNTA0RTFFM0Y0QkEzNEJERTRGNUZFODlCNUZDQjYACgkQveT1/om1 /LaiXwf/c2D331LJax/vyDQpGxNzYqCZyXlILAfGWcrqaH2l3ChU8h29Er34oF7l Mzabvamc5uwAmKACZTzk2CF8Rf6fDK95m/r+0UPTcqUuueUP9Aig4SvwSZlzhqpG wbsIj/kejNhNR08cWzazQVgn6izcPh30n2B5aQPO/27ElkGaD7MBUmgkfHZN1oet Q5pyY+BanxTZH9qpkrq17eq/ciFUoUKazEt+K1ruuAZW6aPSAow0dg31sdh2ioAl RNAYl/n6lF4WL6Hk+NUVvl3AKxvs0HpKG7mvTxdu28v1rE5Vq8lbmW0H75sm9bu3 aeVVEoidqckYnVpKYhpMAjlT2HRmnQ== =aoGA -----END PGP SIGNATURE----- --ShuzWwyVKw5Cs3lDxPHdzYE7z9UF2sIPQ--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0a880448-8ef7-76ff-e531-929dbce9ccf3>