Date: Thu, 30 Apr 2015 13:28:50 -0500 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Mariusz Zaborski <oshogbo@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r282257 - in head: lib/libnv sys/kern sys/sys Message-ID: <55427462.8000504@FreeBSD.org> In-Reply-To: <201504292257.t3TMv5A1091917@svn.freebsd.org> References: <201504292257.t3TMv5A1091917@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --I1DeMETem9Su7PV8gVTs2vTkjrmX4h5QT Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 4/29/2015 5:57 PM, Mariusz Zaborski wrote: > Author: oshogbo > Date: Wed Apr 29 22:57:04 2015 > New Revision: 282257 > URL: https://svnweb.freebsd.org/changeset/base/282257 >=20 > Log: > Remove the nvlist_.*[fv] functions. > =20 > Those functions are problematic, because there is no way to report > memory allocation problems without complicating the API, so we can > either abort or potentially return invalid results. None of which is > acceptable. > =20 > In most cases the caller knows the size of the name, so he can alloca= te > buffer on the stack and use snprintf(3) to prepare the name. > =20 > After some discussion the conclusion is to removed those functions, > which also simplifies the API. > =20 > Discussed with: pjd, rstone > Approved by: pjd (mentor) >=20 > Modified: > head/lib/libnv/Makefile This breaks the ABI of libnv.so.0. You should either bump the SHLIB_MAJOR or consider making this a PRIVATELIB so it is not in the public /lib but in the private /usr/lib/private or use symbol versioning. Being in /lib we must maintain ABI compatibility among the same shlib version. Bumping the SHLIB_MAJOR or moving to PRIVATELIB will require adding the libnv.so.0 to the ObsoleteFiles.inc OLD_FILES list. --=20 Regards, Bryan Drewery --I1DeMETem9Su7PV8gVTs2vTkjrmX4h5QT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJVQnRiAAoJEDXXcbtuRpfP9LEH/2b1mVdxdf6ieQtaQLM0sqH7 NvJUKLzqow+IN7Tsi46U6/6vcUxoW0DdOO6bDU3RCthNlL7QYeNgHaPoHgMj0a6H ar+DU3pEDux6bOhiioXyu2QeX5B2y+yEMjY9CLvRzuMQNY0znjSLcZUv1xbxnro+ 4HMxJi/Kt81V8Om/IGN7OYbVQBFhwfL5HgATJEI1HTZc5fgAOJQeQTbKsMSDDjl4 2HG3M/7/Ovp/4d9z7pw+4AEuYOT5kNQuAgNTh3fpHbuXLKoRSmQqZQyDX5W2hYQf AGdUcmaam7tMD+H6rxniJ2D4ZOxGAbUK20E6iPnasANHNgZY/m3ZdH0/rGvdXYc= =AVHA -----END PGP SIGNATURE----- --I1DeMETem9Su7PV8gVTs2vTkjrmX4h5QT--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?55427462.8000504>