Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 19 Oct 2017 20:04:28 +0200
From:      Tijl Coosemans <tijl@FreeBSD.org>
To:        Jan Beich <jbeich@FreeBSD.org>
Cc:        Steve Wills <swills@FreeBSD.org>, Shane <FreeBSD@ShaneWare.Biz>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r452416 - in head/graphics/opensubdiv: . files
Message-ID:  <20171019200428.104dc058@kalimero.tijl.coosemans.org>
In-Reply-To: <1slz-gioy-wny@FreeBSD.org>
References:  <201710191219.v9JCJbHV026836@repo.freebsd.org> <1slz-gioy-wny@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 19 Oct 2017 19:18:21 +0200 Jan Beich <jbeich@FreeBSD.org> wrote:
> Steve Wills <swills@FreeBSD.org> writes:
>> +	${FIND} ${WRKSRC}/regression -name CMakeLists.txt | ${XARGS} ${REINPLACE_CMD} \
>> +	-e 's|{CMAKE_BINDIR_BASE}|{CMAKE_INSTALL_PREFIX}/share/${PORTNAME}/test|g'  
> 
> According to hier(7) and devel/kyua tests should probably go under
> tests/${PORTNAME}.
> 
> Why use xargs(1) for a feature built into find(1)?
> 
>      -exec utility [argument ...] {} +
>              Same as -exec, except that "{}" is replaced with as many
>              pathnames as possible for each invocation of utility.  This
>              behaviour is similar to that of xargs(1).  The primary always
>              returns true; if at least one invocation of utility returns a
>              non-zero exit status, find will return a non-zero exit status.
> 

XARGS is usually faster because find runs the command for every file
while xargs batches all files in a single command.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20171019200428.104dc058>