From owner-freebsd-pf@FreeBSD.ORG Thu Sep 16 04:10:00 2004 Return-Path: Delivered-To: freebsd-pf@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 674) id 853F616A4CF; Thu, 16 Sep 2004 04:10:00 +0000 (GMT) Delivered-To: mlaier@vampire.homelinux.org Received: (qmail 19347 invoked by alias); 26 Jul 2004 03:49:09 -0000 Delivered-To: unirz@vampire.homelinux.org Received: (qmail 19344 invoked from network); 26 Jul 2004 03:49:09 -0000 Received: from mailstud.rz.uni-karlsruhe.de (129.13.185.210) by pd9e392b4.dip.t-dialin.net with SMTP; 26 Jul 2004 03:49:09 -0000 Received: from spamstud.rz.uni-karlsruhe.de (spamstud.rz.uni-karlsruhe.de [129.13.185.237]) by mailstud.rz.uni-karlsruhe.de with esmtp (Exim 4.34 #1) id 1BowVS-0001so-KO for max.laier@stud.uni-karlsruhe.de; Mon, 26 Jul 2004 05:50:30 +0200 Received: from localhost (exim@[127.0.0.1]) by spamstud.rz.uni-karlsruhe.de with spam-scanned (Exim 4.34 #1) id 1BowVS-0001xA-9w for max.laier@stud.uni-karlsruhe.de; Mon, 26 Jul 2004 05:50:30 +0200 Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.183]) by spamstud.rz.uni-karlsruhe.de with esmtp (Exim 4.34 #1) id 1BowVS-0001wk-6o for max.laier@stud.uni-karlsruhe.de; Mon, 26 Jul 2004 05:50:30 +0200 Received: from [212.227.126.210] (helo=mxng14.kundenserver.de) by moutng.kundenserver.de with esmtp (Exim 3.35 #1) id 1BowVS-0002vQ-00 for max.laier@stud.uni-karlsruhe.de; Mon, 26 Jul 2004 05:50:30 +0200 Received: from [206.53.239.180] (helo=turing.freelists.org) by mxng14.kundenserver.de with esmtp (Exim 3.35 #1) id 1BowVR-0005yY-00 for max@love2party.net; Mon, 26 Jul 2004 05:50:30 +0200 Received: from localhost (localhost [127.0.0.1])ESMTP id 9386F72C1FE; Sun, 25 Jul 2004 22:23:44 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 15806-14; Sun, 25 Jul 2004 22:23:44 -0500 (EST) Received: from turing (localhost [127.0.0.1])ESMTP id EE10F72C265; Sun, 25 Jul 2004 22:23:43 -0500 (EST) Received: with ECARTIS (v1.0.0; list pf4freebsd); Sun, 25 Jul 2004 22:23:27 -0500 (EST) X-Original-To: pf4freebsd@freelists.org Delivered-To: pf4freebsd@freelists.org Received: from localhost (localhost [127.0.0.1])ESMTP id CA5FF72C1FE for ; Sun, 25 Jul 2004 22:23:26 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 15420-24 for ; Sun, 25 Jul 2004 22:23:26 -0500 (EST) Received: from ns.kt-is.co.kr (ns.kt-is.co.kr [211.218.149.125]) ESMTP id CF1F572C29E for ; Sun, 25 Jul 2004 22:23:25 -0500 (EST) Received: from michelle.kt-is.co.kr (ns2.kt-is.co.kr [220.76.118.193]) (authenticated bits=128) by ns.kt-is.co.kr (8.12.10/8.12.10) with ESMTP id i6Q3f2Ah058986 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Mon, 26 Jul 2004 12:41:02 +0900 (KST) Received: from michelle.kt-is.co.kr (localhost.kt-is.co.kr [127.0.0.1]) by michelle.kt-is.co.kr (8.12.10/8.12.10) with ESMTP id i6Q3o6oI001085 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 26 Jul 2004 12:50:06 +0900 (KST) (envelope-from yongari@kt-is.co.kr) Received: (from yongari@localhost) by michelle.kt-is.co.kr (8.12.10/8.12.10/Submit) id i6Q3o536001084; Mon, 26 Jul 2004 12:50:05 +0900 (KST) (envelope-from yongari@kt-is.co.kr) From: Pyun YongHyeon To: Max Laier Message-ID: <20040726035005.GB677@kt-is.co.kr> References: <200407230602.34822.max@love2party.net> <20040723083119.GA3240@kt-is.co.kr> <200407260137.46024.max@love2party.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200407260137.46024.max@love2party.net> User-Agent: Mutt/1.4.1i X-Filter-Version: 1.11a (ns.kt-is.co.kr) X-Virus-Scanned: by amavisd-new at freelists.org X-archive-position: 383 X-ecartis-version: Ecartis v1.0.0 Sender: pf4freebsd-bounce@freelists.org Errors-To: pf4freebsd-bounce@freelists.org X-original-sender: yongari@kt-is.co.kr Precedence: normal X-list: pf4freebsd X-Virus-Scanned: by amavisd-new at freelists.org X-Provags-Forward: max@love2party.net -> max.laier@stud.uni-karlsruhe.de X-Spam-Checker-Version: SpamAssassin 2.61 (1.212.2.1-2003-12-09-exp) on mail6.rz.uni-karlsruhe.de X-Spam-Status: No, hits=-0.7 required=7.0 tests=BAYES_10 autolearn=no version=2.61 X-Spam-Level: X-Scan-Signature: 1d4ba93af80ec5bb071ade0612529e53 X-UID: 494 X-Length: 6899 X-Mailman-Approved-At: Thu, 16 Sep 2004 04:12:49 +0000 cc: pf4freebsd@freelists.org Subject: [pf4freebsd] Re: Strange problem/Need help X-BeenThere: freebsd-pf@freebsd.org X-Mailman-Version: 2.1.1 Reply-To: pf4freebsd@freelists.org List-Id: Technical discussion and general questions about packet filter (pf) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Thu, 16 Sep 2004 04:10:00 -0000 X-Original-Date: Mon, 26 Jul 2004 12:50:05 +0900 X-List-Received-Date: Thu, 16 Sep 2004 04:10:00 -0000 On Mon, Jul 26, 2004 at 01:37:39AM +0200, Max Laier wrote: ... > > How about this? Instead of using hand-optimized code, it would be > > better to use system supplied one. This will work on icc too. > > I have to go out now. Please review the patch and let me know your > > opinions.(It wasn't tested at all.) This one can be used for a while. > > Personally, I really want to import NetBSD's approach. > > I like it. I can recall that we talked about using in_cksum_skip when we frist > did in4_cksum, but for some reason it wasn't useable then (iirc). Can your > remember the complete story? > Well, I guess we talked on the possibility of NetBSD's in[46]_cksum import. NetBSD has highly-optimized version of in[46]_cksum for major architecures(i386, sparc64, arm etc). ATM, FreeBSD don't have in4_cksum() and uses in_cksum() and its variants. In addition, these functions on sparc64 are pure-C code and IPv6 checksum computations are pure-C for all supported architectures. However, this import will have substantial impact on many parts of kernel networking codes and it needs rewriting of checksum validation codes in tcp/udp. It's not easy and needs assembly language gurus for each architectures. But if network gurus in FreeBSD agree with this import, I guess at least we don't have problems on i386. (Bruce Evans?) > Anyway, I ran this on my gateway for two days and it seems okay. I'd like to > have a little more feedback before commiting, though. Please copy attached > in4_cksum.c into src/sys/contrib/pf/netinet, build and run with it. If you > have any shake out, please let me know. > Great. I never thought it would work well due to lack of compilation chance. > Pyun, I assert the original OpenBSD in4_cksum.c copyright on this one. Are you > okay with this solution? > Yes. We SHOULD include original copyright messages here. Regards, Pyun YongHyeon -- Pyun YongHyeon