From owner-svn-src-all@freebsd.org Thu Jun 21 00:48:48 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4F3E11016CF5; Thu, 21 Jun 2018 00:48:48 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9B77F7C6A7; Thu, 21 Jun 2018 00:48:47 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id w5L0mhI3076927; Wed, 20 Jun 2018 17:48:43 -0700 (PDT) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id w5L0mhv8076926; Wed, 20 Jun 2018 17:48:43 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201806210048.w5L0mhv8076926@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r335454 - head/usr.bin/ar In-Reply-To: To: Pedro Giffuni Date: Wed, 20 Jun 2018 17:48:43 -0700 (PDT) CC: rgrimes@freebsd.org, Ed Maste , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jun 2018 00:48:48 -0000 > On 20/06/2018 17:42, Rodney W. Grimes wrote: > >> Author: emaste > >> Date: Wed Jun 20 18:43:17 2018 > >> New Revision: 335454 > >> URL: https://svnweb.freebsd.org/changeset/base/335454 > >> > >> Log: > >> usr.bin/ar: use standard 2-Clause FreeBSD license > >> > >> Many licenses on ar files contained small variations from the standard > >> FreeBSD license text. To avoid license proliferation switch to the usual > >> 2-clause FreeBSD license after obtaining permission from all copyright > >> holders. > >> > >> Approved by: jkoshy, kaiw, kientzle > >> Sponsored by: The FreeBSD Foundation > >> Differential Revision: https://reviews.freebsd.org/D14561 > >> > >> Modified: > >> head/usr.bin/ar/ar.c > >> head/usr.bin/ar/read.c > >> head/usr.bin/ar/util.c > >> > >> Modified: head/usr.bin/ar/ar.c > >> ============================================================================== > >> --- head/usr.bin/ar/ar.c Wed Jun 20 17:37:55 2018 (r335453) > >> +++ head/usr.bin/ar/ar.c Wed Jun 20 18:43:17 2018 (r335454) > >> @@ -1,4 +1,6 @@ > >> /*- > >> + * SPDX-License-Identifier: BSD-3-Clause > >> + * > > I think there may be an error above, commit message says 2 clause, > > license below appears to be 2 clause, yet above we have 3? > Look at all the file: there are two licenses there. My claim still stands, the commit message and reality do not match, Ed claimed that he was switching to 2-clause FreeBSD license, yet it does not appear to actually do that. It further claims that he obtained permission from ALL copyright holders, which also appears to not be true, or he could of removed the 3 clause. The dual license is an even bigger can of worms, as then technically this file is neither BSD-2-Clause nor BSD-3-Clause, but some hybrid that has to be treated specially. Does SPDX have rules for dual tagging a file? I seem to recall that there was some way to do that at least. I am unclear as to it even be legal or valid to have added the 2 clause license on top of the BSD 3 clause license. > Pedro. -- Rod Grimes rgrimes@freebsd.org