From owner-svn-ports-all@FreeBSD.ORG Tue Sep 2 03:54:12 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 1033) id EC520D78; Tue, 2 Sep 2014 03:54:12 +0000 (UTC) Date: Tue, 2 Sep 2014 03:54:12 +0000 From: Alexey Dokuchaev To: Adam Weinberger Subject: Re: svn commit: r366936 - head/devel/avr-libc Message-ID: <20140902035412.GA66317@FreeBSD.org> References: <201409011926.s81JQ4IV011890@svn.freebsd.org> <20140902031509.GB51270@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Adam Weinberger , ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Sep 2014 03:54:13 -0000 On Mon, Sep 01, 2014 at 11:35:52PM -0400, Adam Weinberger wrote: > On 1 Sep, 2014, at 23:15, Alexey Dokuchaev wrote: > > On Mon, Sep 01, 2014 at 07:26:04PM +0000, Adam Weinberger wrote: > >> New Revision: 366936 > >> URL: http://svnweb.freebsd.org/changeset/ports/366936 > >> > >> Log: > >> The doxygen build was failing on 8 and 9 for non-obvious reasons. > >> As a stopgap (and as a favour to anyone building from ports ;-), change > >> the DOCS option to DOXYGEN, and default it to off. > > > > Thanks for bringing more sanity to ports! Doxygen should be default to off > > everywhere indeed. > > The problem with the doxygen issue is that it only negatively affects people > who build from ports. It's generally a build-time dependency only. If maintainer insists on having generated docs in the official packages, they can always do something like this: .if defined(BATCH) || defined(PACKAGE_BUILDING) OPTIONS_DEFAULT+= DOXYGEN .endif Then they would be happy and people who install from the ports tree (the old way) would not be upset by default option as well. > The crucially important thing, from my perspective, is that any port that > requires doxygen HAS TO say so up front! The fact that some ports hide > doxygen behind the DOCS option means that I have to inspect every single > port's Makefile before I install it. Ditto. I cannot emphasize more on how annoying this manual checking is. ./danfe