From owner-svn-ports-all@freebsd.org Thu Nov 21 13:23:41 2019 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E72F21BE784; Thu, 21 Nov 2019 13:23:41 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 47JgHb6vBFz4NNP; Thu, 21 Nov 2019 13:23:39 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id XmQoir0ww17ZDXmQqilef8; Thu, 21 Nov 2019 06:23:37 -0700 X-Authority-Analysis: v=2.3 cv=ZsqT1OzG c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=kj9zAlcOel0A:10 a=MeAgGD-zjQ4A:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=MTRFbHohk7yjyun6a_AA:9 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id 98BA1F78; Thu, 21 Nov 2019 05:23:33 -0800 (PST) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id xALDNX5E010592; Thu, 21 Nov 2019 05:23:33 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id xALDNXHe010589; Thu, 21 Nov 2019 05:23:33 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201911211323.xALDNXHe010589@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Mathieu Arnold cc: Tobias Kortkamp , Cy Schubert , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r518052 - head/sysutils/am-utils In-reply-to: <20191121071847.6564ybobj4ennhcy@atuin.in.mat.cc> References: <201911202129.xAKLTikX056001@repo.freebsd.org> <20191121070924.GA50105@urd.tobik.me> <20191121071847.6564ybobj4ennhcy@atuin.in.mat.cc> Comments: In-reply-to Mathieu Arnold message dated "Thu, 21 Nov 2019 08:18:47 +0100." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Thu, 21 Nov 2019 05:23:33 -0800 X-CMAE-Envelope: MS4wfLx/93b4JS7r2OyJ1YLIyynjPE0+byUWRxFzRG0x+5GinDRwdE14ZxtQ8FTamk+fte3al2VZlFp91W2JMKNNT5Q2KqutgVVXHiSMwTW3buwZskllzp4R Kaq6Pubh+omr/hIjIBWVekdjPzXDMzJ7+j8u8zSS7uF+KUb5IyKBy7oaPlHCc4x2qSLPl/olL8ZlUMTV9TY4J4uR2bl0STMbthkh3NsUwudO/vZqjZs5k9Jm kCZFrgOUxfNvkDEuBcVXyjIFiXZiuZn3sIeOdkuB7o7Uv1MW4C5ak8gdsZBACo0DZ7jj+HhPju/uypTXQTceg0SxOn9oBFvUc/PxITbXwvKag66D+6IhSNxY vEDqhgHl X-Rspamd-Queue-Id: 47JgHb6vBFz4NNP X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=none; spf=none (mx1.freebsd.org: domain of cy.schubert@cschubert.com has no SPF policy when checking 64.59.136.138) smtp.mailfrom=cy.schubert@cschubert.com X-Spamd-Result: default: False [-4.00 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_FIVE(0.00)[5]; RECEIVED_SPAMHAUS_PBL(0.00)[17.125.67.70.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.11]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MV_CASE(0.50)[]; MIME_GOOD(-0.10)[text/plain]; HAS_XAW(0.00)[]; HAS_REPLYTO(0.00)[Cy.Schubert@cschubert.com]; RCPT_COUNT_FIVE(0.00)[6]; REPLYTO_EQ_FROM(0.00)[]; IP_SCORE(-2.30)[ip: (-6.00), ipnet: 64.59.128.0/20(-3.05), asn: 6327(-2.36), country: CA(-0.09)]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_SPF_NA(0.00)[]; RCVD_IN_DNSWL_LOW(-0.10)[138.136.59.64.list.dnswl.org : 127.0.5.1]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:6327, ipnet:64.59.128.0/20, country:CA]; RCVD_TLS_LAST(0.00)[]; FROM_EQ_ENVFROM(0.00)[] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Nov 2019 13:23:42 -0000 In message <20191121071847.6564ybobj4ennhcy@atuin.in.mat.cc>, Mathieu Arnold wr ites: > > > --wcbpoteyztvskbdz > Content-Type: text/plain; charset=us-ascii > Content-Disposition: inline > Content-Transfer-Encoding: quoted-printable > > On Thu, Nov 21, 2019 at 08:09:24AM +0100, Tobias Kortkamp wrote: > > On Wed, Nov 20, 2019 at 09:29:44PM +0000, Cy Schubert wrote: > > > Author: cy > > > Date: Wed Nov 20 21:29:44 2019 > > > New Revision: 518052 > > > URL: https://svnweb.freebsd.org/changeset/ports/518052 > > >=20 > > > Log: > > > Make the installation of the rc script conditional to avoid conflict > > > with base. > > > =20 > > > MFH: 2019Q4 > > > [...] > > > -USE_RC_SUBR=3D amd > > > +RC_USE_RC_SUBR=3D amd > >=20 > > There is no such options helper. It should be > >=20 > > RC_USE=3D RC_SUBR=3Damd > >=20 > > Also the rc script seems to still use /usr/sbin/amd instead of > > %%PREFIX%%/sbin/amd which should probably be fixed too. > > Also, I am unsure of the use of this rc script, if it has the same name > as the base system one, they will have the same variables controlling > them, and both will be started at boot time if amd_enable=3Dyes, which is > probably not what is wanted here. It does install correctly. A partial list of sysutils/ ports, including some of mine. /opt/src/new-ports/sysutils/nut/Makefile 44:USE_RC_SUBR= nut nut_upsmon nut_upslog /opt/src/new-ports/sysutils/openupsd/Makefile 13:USE_RC_SUBR= ${PORTNAME} /opt/src/new-ports/sysutils/afbinit/Makefile 24:USE_RC_SUBR= afbinit /opt/src/new-ports/sysutils/graylog/Makefile 25:USE_RC_SUBR= graylog /opt/src/new-ports/sysutils/bacula9-client/Makefile 9:USE_RC_SUBR= bacula-fd /opt/src/new-ports/sysutils/fcron/Makefile 31:USE_RC_SUBR= fcron /opt/src/new-ports/sysutils/linux-crashplan/Makefile 21:USE_RC_SUBR= crashplan /opt/src/new-ports/sysutils/riak-cs/Makefile 22:USE_RC_SUBR= riak_cs /opt/src/new-ports/sysutils/cpupdate/Makefile 22:USE_RC_SUBR= ${PORTNAME} /opt/src/new-ports/sysutils/syslog-ng321/Makefile 51:USE_RC_SUBR= syslog-ng /opt/src/new-ports/sysutils/fluent-bit/Makefile 20:USE_RC_SUBR= ${PORTNAME} /opt/src/new-ports/sysutils/consul-alerts/Makefile 26:USE_RC_SUBR= ${PORTNAME} /opt/src/new-ports/sysutils/diskcheckd/Makefile 16:USE_RC_SUBR= diskcheckd /opt/src/new-ports/sysutils/asusoled/Makefile 17:USE_RC_SUBR= asusoled oled_clock /opt/src/new-ports/sysutils/pprotectd/Makefile 12:USE_RC_SUBR= ${PORTNAME} /opt/src/new-ports/sysutils/runit/Makefile 20:USE_RC_SUBR= runsvdir /opt/src/new-ports/sysutils/monitord/Makefile 13:USE_RC_SUBR= monitord /opt/src/new-ports/sysutils/sec/Makefile 15:USE_RC_SUBR= sec /opt/src/new-ports/sysutils/firstboot-growfs/Makefile 18:USE_RC_SUBR= firstboot_growfs /opt/src/new-ports/sysutils/syslog-ng319/Makefile 49:USE_RC_SUBR= syslog-ng /opt/src/new-ports/sysutils/rundeck/Makefile 22:USE_RC_SUBR= rundeck The reason for the option is to avoid the conflict. HEAD as of r354902 disables amd by default. The intention is to remove it by 13.0. There is a subsequent (yesterday) update to param.h that would allow me to test OSVERSION. Additionally people can still build and install world WITH_AMD, the option gives us greater flexibility. This of course will change when amd is eventually removed from HEAD. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.