From owner-freebsd-rc@FreeBSD.ORG Sat Jun 8 19:20:43 2013 Return-Path: Delivered-To: rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id BAB56D9E; Sat, 8 Jun 2013 19:20:43 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from mail.allbsd.org (gatekeeper.allbsd.org [IPv6:2001:2f0:104:e001::32]) by mx1.freebsd.org (Postfix) with ESMTP id 0BA6A10E6; Sat, 8 Jun 2013 19:20:39 +0000 (UTC) Received: from alph.d.allbsd.org (p2175-ipbf701funabasi.chiba.ocn.ne.jp [122.25.209.175]) (authenticated bits=128) by mail.allbsd.org (8.14.5/8.14.5) with ESMTP id r58JKMPt042630 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 9 Jun 2013 04:20:32 +0900 (JST) (envelope-from hrs@FreeBSD.org) Received: from localhost (localhost [127.0.0.1]) (authenticated bits=0) by alph.d.allbsd.org (8.14.5/8.14.5) with ESMTP id r58JKK9F061043; Sun, 9 Jun 2013 04:20:22 +0900 (JST) (envelope-from hrs@FreeBSD.org) Date: Sun, 09 Jun 2013 04:19:03 +0900 (JST) Message-Id: <20130609.041903.541782050134731313.hrs@allbsd.org> To: smh@FreeBSD.org Subject: Re: Feeback on patch to add ZFS support to mdconfig rc.d scripts From: Hiroki Sato In-Reply-To: References: X-PGPkey-fingerprint: BDB3 443F A5DD B3D0 A530 FFD7 4F2C D3D8 2793 CF2D X-Mailer: Mew version 6.5 on Emacs 24.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Multipart/Signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="--Security_Multipart(Sun_Jun__9_04_19_03_2013_534)--" Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.97.4 at gatekeeper.allbsd.org X-Virus-Status: Clean X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (mail.allbsd.org [133.31.130.32]); Sun, 09 Jun 2013 04:20:32 +0900 (JST) X-Spam-Status: No, score=-94.5 required=13.0 tests=CONTENT_TYPE_PRESENT, ONLY1HOPDIRECT,RCVD_IN_PBL,SAMEHELOBY2HOP,USER_IN_WHITELIST autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on gatekeeper.allbsd.org Cc: rc@FreeBSD.org, zfs-devel@FreeBSD.org X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Jun 2013 19:20:43 -0000 ----Security_Multipart(Sun_Jun__9_04_19_03_2013_534)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit "Steven Hartland" wrote in : sm> Attached is a patch which adds ZFS support to the sm> mdconfig rc.d scritps along with some other little sm> fixes while I was there. sm> sm> Our use case for this here is to create a ZFS pool sm> on a swap backed node for temporary data which supports sm> all the cool features of ZFS, for us thats compression. sm> sm> Possible enhancements, suggested by pjd in IRC include sm> default flags such as:-o cachefile=none sm> sm> Current summary:- sm> ======= sm> Add ZFS pool creation support to mdconfig rc.d script sm> sm> Fix failure error redirection in mount check sm> sm> Fix invalid configuration detection enabling -t vnode sm> to be skipped if -f is specified as supported sm> by mdconfig. sm> sm> Fix fsck not working if mount point is not present in fstab. sm> sm> TODO: update rc.conf man page sm> ======= I think this should be separated into adding non-fs md support into rc.d/mdconfig and on-the-fly zpool creation/import into rc.d/zfs since the rc.d/mdconfig script does not (and should not) depend on zfs.ko module. rc.d/mdconfig is located before mountcritlocal, so probably rc.d/zfs_md or something is needed just after rc.d/mdconfig2. -- Hiroki ----Security_Multipart(Sun_Jun__9_04_19_03_2013_534)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (FreeBSD) iEYEABECAAYFAlGzg6cACgkQTyzT2CeTzy3ABgCZARMSpN4m7I251NYJHcxJbQNi mhIAn2AGQsDRK99iL9uo13uU0uFcNJlV =yMgS -----END PGP SIGNATURE----- ----Security_Multipart(Sun_Jun__9_04_19_03_2013_534)----