From owner-cvs-all Sun Jun 23 13:53:21 2002 Delivered-To: cvs-all@freebsd.org Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by hub.freebsd.org (Postfix) with ESMTP id C19B737B400; Sun, 23 Jun 2002 13:52:56 -0700 (PDT) Received: from fledge.watson.org (fledge.pr.watson.org [192.0.2.3]) by fledge.watson.org (8.12.3/8.12.3) with SMTP id g5NKqtw6009506; Sun, 23 Jun 2002 16:52:55 -0400 (EDT) (envelope-from robert@fledge.watson.org) Date: Sun, 23 Jun 2002 16:52:55 -0400 (EDT) From: Robert Watson X-Sender: robert@fledge.watson.org To: Luigi Rizzo Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet ip_input.c In-Reply-To: <200206232048.g5NKmQN17703@freefall.freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Yeah, I was actually thinking about committing almost the same comment on the mbuf allocation in ip_forward(). Essentially, the mbuf is only needed in failure cases, and therefore we pessimize the success case. We should just cache a 'struct ip' in the stack frame of ip_forward() and tweak the code we call to use that, presumably. Robert N M Watson FreeBSD Core Team, TrustedBSD Projects robert@fledge.watson.org Network Associates Laboratories On Sun, 23 Jun 2002, Luigi Rizzo wrote: > luigi 2002/06/23 13:48:26 PDT > > Modified files: > sys/netinet ip_input.c > Log: > Move some global variables in more appropriate places. > > Add XXX comments to mark places which need to be taken care of > if we want to remove this part of the kernel from Giant. > > Add a comment on a potential performance problem with ip_forward() > > Revision Changes Path > 1.203 +28 -3 src/sys/netinet/ip_input.c > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message