From owner-freebsd-current@FreeBSD.ORG Sun Nov 27 23:51:05 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 37686106566B for ; Sun, 27 Nov 2011 23:51:05 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: from mail-ww0-f50.google.com (mail-ww0-f50.google.com [74.125.82.50]) by mx1.freebsd.org (Postfix) with ESMTP id 9F8038FC18 for ; Sun, 27 Nov 2011 23:51:04 +0000 (UTC) Received: by wwe5 with SMTP id 5so7561048wwe.31 for ; Sun, 27 Nov 2011 15:51:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=blEXbJ0p8z5V+sj34v0ElUGsXRM0MgIo91KvSvBEzB4=; b=wcYCz1BdRXKJg7wHuKvhSmJIpInCS1upHB3StTjQ77O5KakNJ1KtG8m2g3ekjzcYTH v9J8OThayB8/39/J8MW6HNdZL2BzkhS3WUmiQbvHRSes9SiVX+Kr0AIlxQBjxoQ5c5Bx +o8p16WUMGLzfZ2TmBxW+9X+ru9wMgVkFE4Mo= MIME-Version: 1.0 Received: by 10.180.90.6 with SMTP id bs6mr41773126wib.63.1322437863531; Sun, 27 Nov 2011 15:51:03 -0800 (PST) Received: by 10.180.101.102 with HTTP; Sun, 27 Nov 2011 15:51:03 -0800 (PST) In-Reply-To: <4ED2CAFF.7070608@FreeBSD.org> References: <4ED2CAFF.7070608@FreeBSD.org> Date: Sun, 27 Nov 2011 18:51:03 -0500 Message-ID: From: Ryan Stone To: Andriy Gapon Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: FreeBSD current Subject: Re: array index of '-16' indexes before the beginning of the array X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Nov 2011 23:51:05 -0000 On Sun, Nov 27, 2011 at 6:42 PM, Andriy Gapon wrote: > > Looks like clang has found a real issue here: > /usr/src/sys/x86/x86/local_apic.c:311:2: warning: array index of '-16' in= dexes > before the beginning of the array [-Warray-bounds] > =A0 =A0 =A0 =A0lapics[apic_id].la_ioint_irqs[IDT_DTRACE_RET - APIC_IO_INT= S] =3D > IRQ_DTRACE_RET; > > IDT_DTRACE_RET (0x20) indeed seems to be less than APIC_IO_INTS. Uh-oh, I appear to have broken this in r227290. I'll try to figure out what's actually supposed to be done here.