From owner-freebsd-gnome Mon Feb 25 0:22:28 2002 Delivered-To: freebsd-gnome@freebsd.org Received: from dragon.nuxi.com (trang.nuxi.com [66.92.13.169]) by hub.freebsd.org (Postfix) with ESMTP id 40EBE37B402; Mon, 25 Feb 2002 00:22:25 -0800 (PST) Received: (from obrien@localhost) by dragon.nuxi.com (8.11.6/8.11.1) id g1P8MPE29239; Mon, 25 Feb 2002 00:22:25 -0800 (PST) (envelope-from obrien) Date: Mon, 25 Feb 2002 00:22:25 -0800 From: "David O'Brien" To: Maxim Sobolev Cc: gnome@FreeBSD.org Subject: Re: bsd.gnome.mk needs this patch Message-ID: <20020225002225.A29201@dragon.nuxi.com> Reply-To: obrien@FreeBSD.org References: <20020224222548.A66147@dragon.nuxi.com> <3C79F2DA.69EAE6A0@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <3C79F2DA.69EAE6A0@FreeBSD.org>; from sobomax@FreeBSD.org on Mon, Feb 25, 2002 at 10:16:26AM +0200 X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-freebsd-gnome@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, Feb 25, 2002 at 10:16:26AM +0200, Maxim Sobolev wrote: > > Please commit ASAP. USE_MOTIF sets USE_XLIB, which then ensures the X11 > > libs are installed. GTK(GNOME) should do the same. > > > > Index: bsd.gnome.mk > > =================================================================== > > RCS file: /home/ncvs/ports/Mk/bsd.gnome.mk,v > > retrieving revision 1.13 > > diff -u -r1.13 bsd.gnome.mk > > --- bsd.gnome.mk 13 Jan 2002 12:05:07 -0000 1.13 > > +++ bsd.gnome.mk 25 Feb 2002 06:24:39 -0000 > > @@ -220,6 +220,7 @@ > > .endif > > .if defined(USE_GTK) > > USE_GLIB= yes > > +USE_XLIB= yes > > .endif > > > > .if defined(USE_ESOUND) > > No, because X11 dependency inherited along with gtk+ dependency. WRONG. It is only done if gtk was built as a port. Look, I need this for the Vim port -- there should be a knob to let you know that the X libs are needed. If you are linking with gtk, you need the X libs. In EVERY other case, USE_XLIB is set, except for the USE_GTK case. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-gnome" in the body of the message