From owner-cvs-all@FreeBSD.ORG  Thu Mar 29 17:53:07 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 0ECA316A401;
	Thu, 29 Mar 2007 17:53:07 +0000 (UTC) (envelope-from mtm@FreeBSD.Org)
Received: from mx1.ethionet.et (mx1.ethionet.et [213.55.64.53])
	by mx1.freebsd.org (Postfix) with ESMTP id 6CF0013C4AE;
	Thu, 29 Mar 2007 17:53:06 +0000 (UTC) (envelope-from mtm@FreeBSD.Org)
Received: from mx1.ethionet.et (localhost [127.0.0.1])
	by localhost.ethionet.et (Postfix) with ESMTP id 5425A5008;
	Thu, 29 Mar 2007 20:18:35 +0300 (EAT)
Received: from rogue.navcom.lan (unknown [213.55.64.98])by mx1.ethionet.et (
	Postfix) with SMTP id 232834FE7;Thu, 29 Mar 2007 20:18:34 +0300 (EAT)
Received: by rogue.navcom.lan (Postfix, from userid 1001)id 9443F17024; Thu,
	29 Mar 2007 20:24:09 +0300 (EAT)
Date: Thu, 29 Mar 2007 20:24:09 +0300
From: Mike Makonnen <mtm@FreeBSD.Org>
To: "Andrey A. Chernov" <ache@FreeBSD.org>
Message-ID: <20070329172409.GA38703@rogue.navcom.lan>
References: <200703291055.l2TAtYu4038445@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain;
	charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200703291055.l2TAtYu4038445@repoman.freebsd.org>
User-Agent: Mutt/1.4.2.2i
X-Operating-System: FreeBSD/7.0-CURRENT (i386)
X-imss-version: 2.46
X-imss-result: Passed
X-imss-scores: Clean:99.90000 C:2 M:3 S:6 R:5
X-imss-settings: Baseline:4 C:3 M:3 S:4 R:3 (1.0000 1.0000)
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/etc network.subr
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Mar 2007 17:53:07 -0000

On Thu, Mar 29, 2007 at 10:55:34AM +0000, Andrey A. Chernov wrote:
> ache        2007-03-29 10:55:34 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     etc                  network.subr 
>   Log:
>   Fix get_if_var() with 3 args (i.e. with default)
>   
>   All xxx_<ifname> flags are set to empty strings automatically earlier so
>   eval echo \${${prefix}${_if}${suffix}-${_default}}
>   not substitute the default but return just the empty string.
>   Fix it using
>   eval echo \${${prefix}${_if}${suffix}:-${_default}}
>   (i.e. treat empty strings as unset)
>   
>   The bug manifistates itself with the following warning from checkyesno():
>   /etc/rc.d/dhclient: WARNING: $background_dhclient is not set properly -
>   see rc.conf(5)
>   
>   Revision  Changes    Path
>   1.178     +1 -1      src/etc/network.subr

Please back this out.

Your change doesn't fix the bug. It only hides it. The bug was fixed in
rc.d/dhclient v1.28. 

Cheers.
-- 
Mike Makonnen  | GPG-KEY: http://www.identd.net/~mtm/mtm.asc
mtm@identd.net | Fingerprint: AC7B 5672 2D11 F4D0 EBF8  5279 5359 2B82 7CD4 1F55
mtm@FreeBSD.Org| FreeBSD - Unleash the Daemon !