Date: Thu, 30 Apr 2015 21:39:02 +0200 From: Tijl Coosemans <tijl@FreeBSD.org> To: Bryan Drewery <bdrewery@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org Subject: Re: svn commit: r282275 - in stable/10: . bin/csh contrib/smbfs/include/netsmb contrib/smbfs/lib/smb include lib/libarchive lib/libc/iconv lib/libc/locale lib/libiconv_modules/BIG5 lib/libiconv_modules... Message-ID: <20150430213902.21ee48fc@kalimero.tijl.coosemans.org> In-Reply-To: <55427802.80300@FreeBSD.org> References: <201504301608.t3UG8mNS004104@svn.freebsd.org> <55427802.80300@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Sig_/6klm17pZzuaratc4hqX+at0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Thu, 30 Apr 2015 13:44:18 -0500 Bryan Drewery <bdrewery@FreeBSD.org> wro= te: > On 4/30/2015 11:08 AM, Tijl Coosemans wrote: >> Author: tijl >> Date: Thu Apr 30 16:08:47 2015 >> New Revision: 282275 >> URL: https://svnweb.freebsd.org/changeset/base/282275 >>=20 >> Log: >> MFC r275805: >> =20 >> Fix incorrect type of "invalids" argument in __iconv() prototype. >> =20 >> MFC r281550,281591: >> =20 >> Remove the const qualifier from iconv(3) to comply with POSIX: >> http://pubs.opengroup.org/onlinepubs/9699919799/functions/iconv.html >> =20 >> Adjust all code that calls iconv. >> =20 >> PR: 199099 >>=20 >> Modified: >> stable/10/UPDATING >> stable/10/bin/csh/config.h >> stable/10/bin/csh/iconv_stub.h >> stable/10/contrib/smbfs/include/netsmb/smb_lib.h >> stable/10/contrib/smbfs/lib/smb/nls.c >> stable/10/contrib/smbfs/lib/smb/print.c >> stable/10/contrib/smbfs/lib/smb/rq.c >> stable/10/include/iconv.h >> stable/10/lib/libarchive/Makefile >> stable/10/lib/libc/iconv/__iconv.c >> stable/10/lib/libc/iconv/bsd_iconv.c >> stable/10/lib/libc/iconv/citrus_iconv.h >> stable/10/lib/libc/iconv/citrus_iconv_local.h >> stable/10/lib/libc/iconv/citrus_none.c >> stable/10/lib/libc/iconv/citrus_stdenc.h >> stable/10/lib/libc/iconv/citrus_stdenc_local.h >> stable/10/lib/libc/iconv/citrus_stdenc_template.h >> stable/10/lib/libc/iconv/iconv-internal.h >> stable/10/lib/libc/iconv/iconv.3 >> stable/10/lib/libc/iconv/iconv.c >> stable/10/lib/libc/iconv/iconv_compat.c >> stable/10/lib/libc/locale/cXXrtomb_iconv.h >> stable/10/lib/libc/locale/mbrtocXX_iconv.h >> stable/10/lib/libiconv_modules/BIG5/citrus_big5.c >> stable/10/lib/libiconv_modules/DECHanyu/citrus_dechanyu.c >> stable/10/lib/libiconv_modules/EUC/citrus_euc.c >> stable/10/lib/libiconv_modules/EUCTW/citrus_euctw.c >> stable/10/lib/libiconv_modules/GBK2K/citrus_gbk2k.c >> stable/10/lib/libiconv_modules/HZ/citrus_hz.c >> stable/10/lib/libiconv_modules/ISO2022/citrus_iso2022.c >> stable/10/lib/libiconv_modules/JOHAB/citrus_johab.c >> stable/10/lib/libiconv_modules/MSKanji/citrus_mskanji.c >> stable/10/lib/libiconv_modules/UES/citrus_ues.c >> stable/10/lib/libiconv_modules/UTF1632/citrus_utf1632.c >> stable/10/lib/libiconv_modules/UTF7/citrus_utf7.c >> stable/10/lib/libiconv_modules/UTF8/citrus_utf8.c >> stable/10/lib/libiconv_modules/VIQR/citrus_viqr.c >> stable/10/lib/libiconv_modules/ZW/citrus_zw.c >> stable/10/lib/libiconv_modules/iconv_none/citrus_iconv_none.c >> stable/10/lib/libiconv_modules/iconv_std/citrus_iconv_std.c >> stable/10/lib/libkiconv/xlat16_iconv.c >> stable/10/sys/sys/param.h >> stable/10/usr.bin/iconv/iconv.c >> Directory Properties: >> stable/10/ (props changed) >>=20 >> Modified: stable/10/UPDATING >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >> --- stable/10/UPDATING Thu Apr 30 15:48:48 2015 (r282274) >> +++ stable/10/UPDATING Thu Apr 30 16:08:47 2015 (r282275) >> @@ -16,6 +16,10 @@ from older versions of FreeBSD, try WITH >> stable/10, and then rebuild without this option. The bootstrap process = from >> older version of current is a bit fragile. >> =20 >> +20150430: >> + The const qualifier has been removed from iconv(3) to comply with >> + POSIX. The ports tree is aware of this from r384038 onwards. >> + >=20 > Being an ABI change this seems wrong to MFC. Binaries are not only built > from Ports. >=20 > For a binary built on 10.1 will this change cause any issues? Removing const from a function parameter is not an ABI change, so there are no issues for binaries. The worst you can run into is a warning/error from a compiler (when you pass a const char** argument to what is now a char** parameter), but this should be trivial to fix. --Sig_/6klm17pZzuaratc4hqX+at0 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iF4EAREKAAYFAlVChNYACgkQfoCS2CCgtitKxwD/bMbwoaX6u5LAOUif8z78FLAR k5rIvzRZDcymResjj28A/iNkn6c+7Dabj1y8VpFSBthz4rDhMyZ+IYiCLIowFM+x =mktF -----END PGP SIGNATURE----- --Sig_/6klm17pZzuaratc4hqX+at0--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150430213902.21ee48fc>