From owner-freebsd-net@freebsd.org Wed Mar 21 20:40:27 2018 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 495FAF65431 for ; Wed, 21 Mar 2018 20:40:27 +0000 (UTC) (envelope-from v.maffione@gmail.com) Received: from mail-qk0-x236.google.com (mail-qk0-x236.google.com [IPv6:2607:f8b0:400d:c09::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DAF3986CAA for ; Wed, 21 Mar 2018 20:40:26 +0000 (UTC) (envelope-from v.maffione@gmail.com) Received: by mail-qk0-x236.google.com with SMTP id s188so6948483qkb.2 for ; Wed, 21 Mar 2018 13:40:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=0mrWqNKoB4Mv6nYtAdPI44d7XFuoWs+Ss03BecObgeI=; b=tz4KaSdKfb/Ap5swWFbnJiPkTe1Iz+JrwyBBN46bupIGd0472Ymp+hQ7DZxveqpofP YUNCWhT4uzg8GCSDcN1FxVN7r8wd95G+FTlKHQpkuhTDhlScXhNBfEJsOeR0n4RVwb02 cayLbik5tOiLNDVjF5a+9CVhcsLPZERgV6Y/zhFucZkHWqsG2jw8gfrYHfeS3B1sFffm UwB13c+3s/+gFOlWDscQ5q1gDnuB/P1ZYcKTe6clXTJ8WVb6yphi4zuwsLF1H+Mr/SZf CeBU9YrWo52pO+YiCfhdDLShCtEGBUfic5rAja5QBfHKFmi7Y6hPwhT7AymmGip3K0F3 etlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=0mrWqNKoB4Mv6nYtAdPI44d7XFuoWs+Ss03BecObgeI=; b=Viq3vguuZfJpkIVJeTgbQwbGT5hxbJ8HxnZaPytkPbkNjDxOrlQhGk1Ux6r6ge9i1g v+qF/XaTZKaDQOR3AHc1PEaSpQk0ujaXsn8Hf/bbuMj97EW8KGOzzFtly8Os8ijkLN5D zwGnLSsIqkwabVIoQBCavzLW5ae7VP2agTq/6j9lKkzpGh3/xKY2UVq7cTq+ym/Z+npG uOcgsPVWbT8E1ElsxWeJpTzZkLrW2U73+3uHOJbRLpw5vv+emuvX99zQxZ3yDA2kdvUs nKs7imFP4UqcKfrQ+mVawGzL18x6S2uvV3SV3760DZCc2lYkFxjQLcFjAeM132QDK4hf rTfA== X-Gm-Message-State: AElRT7FgmKTYS2z620/ZoIAThSYpyqEw9jYAUJ+Istf7Xq9hIGXArkEq YQUGMpmUvgcuXqWr84CipfsuJa4aFVDV4Ou0WV0= X-Google-Smtp-Source: AG47ELtU5pBFIRO6hcc0wifnlPZzBb+0lUFo2w8QZEAYYNkfiRAIynQ/fKs9TUo03FmRC5n5RUlEYcUD8CrPtIQuRZg= X-Received: by 10.55.192.5 with SMTP id o5mr31634825qki.87.1521664826259; Wed, 21 Mar 2018 13:40:26 -0700 (PDT) MIME-Version: 1.0 Received: by 10.12.195.204 with HTTP; Wed, 21 Mar 2018 13:40:25 -0700 (PDT) In-Reply-To: <5AB166DC.8060708@cox.net> References: <5AAC49BE.3030508@cox.net> <5AAC4A96.1040107@cox.net> <5AB01439.3090003@cox.net> <5AB166DC.8060708@cox.net> From: Vincenzo Maffione Date: Wed, 21 Mar 2018 21:40:25 +0100 Message-ID: Subject: Re: netmap ixgbevf mtu To: Joe Buehler Cc: "freebsd-net@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Mar 2018 20:40:27 -0000 I see. Unfortunately this breaks the API, so I don't think we can accept it. We should probably sum up the fragment lengths, remember which one was the first descriptor and write the olinfo field when we process the last descriptor ... I hope this does not slow down the simpler case where NS_MOREFRAG is not used. In any, case we should move this discussion to the github, if possible (so that the issue gets tracked). Cheers, Vincenzo 2018-03-20 20:54 GMT+01:00 Joe Buehler : > Attached is a patch that allows fragmented TX with the ixgbevf driver. > > For the first TX buffer set the slot length to the full length of the > frame and make sure that the slot buffer is fully filled. For succeeding > slots just set the length to the amount of the buffer filled. > > Not intended as the perfect solution but it works fine for my situation. > > Joe Buehler > > -- Vincenzo Maffione