From owner-svn-ports-all@freebsd.org Thu Aug 25 09:11:49 2016 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7D5B2BC59B9; Thu, 25 Aug 2016 09:11:49 +0000 (UTC) (envelope-from crees@physics.org) Received: from mail37c50.megamailservers.eu (mail230c50.megamailservers.eu [91.136.10.240]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 05CC216F2; Thu, 25 Aug 2016 09:11:47 +0000 (UTC) (envelope-from crees@physics.org) X-Authenticated-User: bayofrum.uwclub.net Received: from pegasus.bayofrum.net (host-2-102-106-111.as13285.net [2.102.106.111]) (authenticated bits=0) by mail37c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id u7P9Bgm7016012; Thu, 25 Aug 2016 09:11:43 +0000 Received: from android-4497c5999ce4d9aa.bayofrum.net (android-4497c5999ce4d9aa.bayofrum.net [192.168.1.115]) by pegasus.bayofrum.net (Postfix) with ESMTPSA id 3D5464D857; Thu, 25 Aug 2016 10:11:39 +0100 (BST) User-Agent: K-9 Mail for Android In-Reply-To: <117832A4D3327FBB22E27C1A@atuin.in.mat.cc> References: <201608250219.u7P2JFVf030918@repo.freebsd.org> <117832A4D3327FBB22E27C1A@atuin.in.mat.cc> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Subject: Re: svn commit: r420830 - in head/databases: . neo4j neo4j/files From: Chris Rees Date: Thu, 25 Aug 2016 10:11:41 +0100 To: Mathieu Arnold , Chris Rees , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Message-ID: <6C64CE8A-06BF-48F8-A7B0-B4F7D9552061@physics.org> X-bayofrum-MailScanner-Information: Please contact the ISP for more information X-bayofrum-MailScanner-ID: 3D5464D857.A2A9A X-bayofrum-MailScanner: Found to be clean X-bayofrum-MailScanner-From: crees@physics.org X-Spam-Status: No X-CTCH-RefID: str=0001.0A0B0201.57BEB64F.01C8, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.1 cv=R/Y6R7hX c=1 sm=1 tr=0 a=gIyif6r13gc5Hj8RuoB4yw==:117 a=gIyif6r13gc5Hj8RuoB4yw==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=IkcTkHD0fZMA:10 a=7z1cN_iqozsA:10 a=6I5d2MoRAAAA:8 a=wW0svjmTV1EgS_fDcN4A:9 a=QEXdDO2ut3YA:10 a=IjZwj45LgO3ly-622nXo:22 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Aug 2016 09:11:49 -0000 On 25 August 2016 09:47:07 BST, Mathieu Arnold wrote: > > >+--On 25 août 2016 02:19:15 +0000 Chris Rees wrote: >| +post-patch: >| + ${REINPLACE_CMD} ${_SUB_LIST_TEMP} ${WRKSRC}/bin/neo4j-shared.sh \ >| + ${WRKSRC}/conf/neo4j.conf > >_SUB_LIST_TEMP is an undocumented *internal* framework variable. It >should >*never* be used in a port's Makefile. >With the amount of things I'm rewriting, it may disapear any day, and I >will not hunt down the ports that use it where they should not. I must say I had a reservation about using it, although I think I've seen this done before. I think this should be exposed as ${SUB_SED_COMMAND} or something because it's useful. Is there a mechanism for having patchfiles as SUB_FILES? Chris -- Sent from my Android device with K-9 Mail. Please excuse my brevity. -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.