Date: Mon, 9 Jun 2003 13:54:21 +0300 From: Ruslan Ermilov <ru@freebsd.org> To: netchild@freebsd.org Cc: lioux@freebsd.org Subject: Re: Re Regression: Playing QT files from mplayer stopped working in 5.1 Message-ID: <20030609105421.GB46569@sunbay.com> In-Reply-To: <20030609112245.573a7e5f.Alexander@Leidinger.net> References: <200306090828.h598SYqI008965@open.nlnetlabs.nl> <20030609112245.573a7e5f.Alexander@Leidinger.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--MfFXiAuoTsnnDAfZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 09, 2003 at 11:22:45AM +0200, Alexander Leidinger wrote: > On Mon, 9 Jun 2003 10:28:33 +0200 > ted@NLnetLabs.nl (Ted Lindgreen) wrote: >=20 > > However, I guess that mplayer has had this error already, but that > > a change in uthread_close.c as of May 31 has caused this problem > > to show up now. > > In particular: the unprotected usage of a very large value of "fd" > > in "_thread_fd_table[fd]" leads to the segmentation violation. > >=20 > > Previously the systemcall just returned an error without getting > > into a segmentation violation. >=20 > > Question: > > shouldn't _close in uthread_close.c do some sanity check on "fd" > > before using it as an array index? >=20 > Try the attached patch. >=20 Alexander, This patch looks great. Please commit it. --=20 Ruslan Ermilov Sysadmin and DBA, ru@sunbay.com Sunbay Software Ltd, ru@FreeBSD.org FreeBSD committer --MfFXiAuoTsnnDAfZ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD8DBQE+5GddUkv4P6juNwoRAgvKAJ4iy1NKV3vOnb8FEhr9FHkmNAqfSACfdpec ZdZ64gtwy0Xxl6U43cWJoxM= =rQ8J -----END PGP SIGNATURE----- --MfFXiAuoTsnnDAfZ--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030609105421.GB46569>