Date: Fri, 14 Aug 2015 15:16:50 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Pedro Giffuni <pfg@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r286760 - in head/lib/libc: . secure sys Message-ID: <20150814121649.GN2072@kib.kiev.ua> In-Reply-To: <85D0049C-488D-45E3-8E60-8F9442CFC8B2@FreeBSD.org> References: <201508140303.t7E33EnN095618@repo.freebsd.org> <20150814112443.GL2072@kib.kiev.ua> <85D0049C-488D-45E3-8E60-8F9442CFC8B2@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Aug 14, 2015 at 07:02:25AM -0500, Pedro Giffuni wrote: > Hello; > > > Il giorno 14/ago/2015, alle ore 06:24, Konstantin Belousov <kostikbel@gmail.com> ha scritto: > > > > On Fri, Aug 14, 2015 at 03:03:14AM +0000, Pedro F. Giffuni wrote: > >> +/* > >> + * It'd be nice to have this automatically generated, but we don't > >> + * know to what version they will eventually belong, so for now > >> + * it has to be manual. > >> + */ > > The comment does not make a bit of sense. > > It also raises the question whether the author(s) of the change > > ever understand what do they change. > > > > It was blindly copy/pasted from the originating lib/libc/sys/Symbol.map. In the sys/Symbol.map it referenced the generated symbols for the syscall trampolines. You could clarify this in the comment, by limiting its scope to the syscall symbols. But I do not object to removing it from sys/Symbol.map. > > I will remove both stale comments. Ok.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150814121649.GN2072>