From owner-freebsd-i386@FreeBSD.ORG  Thu Oct  8 01:47:03 2009
Return-Path: <owner-freebsd-i386@FreeBSD.ORG>
Delivered-To: freebsd-i386@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 6EEAF10656A4
	for <freebsd-i386@FreeBSD.org>; Thu,  8 Oct 2009 01:47:03 +0000 (UTC)
	(envelope-from brde@optusnet.com.au)
Received: from fallbackmx07.syd.optusnet.com.au
	(fallbackmx07.syd.optusnet.com.au [211.29.132.9])
	by mx1.freebsd.org (Postfix) with ESMTP id 08DEC8FC2C
	for <freebsd-i386@FreeBSD.org>; Thu,  8 Oct 2009 01:47:02 +0000 (UTC)
Received: from mail02.syd.optusnet.com.au (mail02.syd.optusnet.com.au
	[211.29.132.183])
	by fallbackmx07.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id
	n97N2x9V021332
	for <freebsd-i386@FreeBSD.org>; Thu, 8 Oct 2009 10:02:59 +1100
Received: from c122-107-125-150.carlnfd1.nsw.optusnet.com.au
	(c122-107-125-150.carlnfd1.nsw.optusnet.com.au [122.107.125.150])
	by mail02.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id
	n97N2twb008130
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Thu, 8 Oct 2009 10:02:56 +1100
Date: Thu, 8 Oct 2009 10:02:50 +1100 (EST)
From: Bruce Evans <brde@optusnet.com.au>
X-X-Sender: bde@delplex.bde.org
To: Sergey Kuritsin <kuritsin_s_v@mail.ru>
In-Reply-To: <200910071455.n97Et1dM094875@www.freebsd.org>
Message-ID: <20091008100024.K754@delplex.bde.org>
References: <200910071455.n97Et1dM094875@www.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: freebsd-gnats-submit@FreeBSD.org, freebsd-i386@FreeBSD.org
Subject: Re: i386/139403: absense of AUE_NULL
X-BeenThere: freebsd-i386@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: I386-specific issues for FreeBSD <freebsd-i386.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-i386>,
	<mailto:freebsd-i386-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-i386>
List-Post: <mailto:freebsd-i386@freebsd.org>
List-Help: <mailto:freebsd-i386-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-i386>,
	<mailto:freebsd-i386-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Oct 2009 01:47:03 -0000

On Wed, 7 Oct 2009, Sergey Kuritsin wrote:

>> Description:
> There is no definition of AUE_NULL constant in sys/sysent.h (or in bsm/audit.h). When you include in source file sys/sysent.h header compiler says that thereis no definition of AUE_NULL.
>> How-To-Repeat:
> Use in your code macro SYSCALL_MODULE form sys/sysent.h
>
>
>> Fix:
> It can be fixed by adding #define AUE_NULL 0 in bsm/audit.h for example.

Here is my old mail about this bug and related messes in headers.

I'm trying to build an old module under FreeBSD-7.  It failed to compile
because SYSCALL_MODULE() uses AUE_NULL which is never defined despite
massive namespace pollution (#include <bsm/audit.h>) in <sys/sysent.h>.
AUE_NULL is defined in <bsm/audit_kevents.h> but the pollution doesn't
extend that far.  <sys/sysent.h> seems to use only au_event_t directly
from bsm, and only AUE_NULL indirectly from bsm.

The <bsm/audit_kevents.h> pollution is machine-generated into
<sys/sysproto.h> together with lots of other pollution.  Most of
the original pollution in <sys/sysproto.h> is unnecessary now that
there is a non-polluting header for sigset_t, but there is now
about 10 times as much as when I started cleaning it up.  I still
remove it all in my version using the following hack:

<hack deleted>

The FreeBSD-7 sysproto.h seems to use only AUE_NULL from
<bsm/audit_kevents.h>.  That is a lot of pollution for a fancy spelling of 0.

Bruce