From owner-freebsd-net@freebsd.org Wed Sep 18 02:26:48 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D1B10EE511 for ; Wed, 18 Sep 2019 02:26:48 +0000 (UTC) (envelope-from vm.finance2@gmail.com) Received: from mail-io1-xd43.google.com (mail-io1-xd43.google.com [IPv6:2607:f8b0:4864:20::d43]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46Y3lC63K3z3DS9 for ; Wed, 18 Sep 2019 02:26:47 +0000 (UTC) (envelope-from vm.finance2@gmail.com) Received: by mail-io1-xd43.google.com with SMTP id r26so12453275ioh.8 for ; Tue, 17 Sep 2019 19:26:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lG3Kej9wTp0Z+Jgn6wAUIVZsDGOSRZsNV0V1wuLAHv4=; b=cuyxfh1UVjlapZ+ZINASaWoj4ACIzvXPKhTsJkvinZ/UINAgn02E0IjKs0HaT7oiZf DrVOjoa8502+u/KY6LUegleZHslUDZnUWSRoC50g6sPtoquw3NFs+bBzo0FTDBp8rMMi 5EtLwTn/T0sJL3fWYzWCK9N+dfUkLKqwgQ+ZT32WC6CMex53Qq90DRpyaGv1QzyQv8YE 9OhMHWdV3OCHM908v6qtTc0JXcStwj/TVfVHji1049dxJ0h41yvDmeVQlLOYsIcsPDzu dFw6XITfnxLbh1pVnPMM96h9IzbrjzkLhrMIjn+2MzA6OUcwec9fkzgkR3JzESMOvxYL ydng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lG3Kej9wTp0Z+Jgn6wAUIVZsDGOSRZsNV0V1wuLAHv4=; b=QfAWzndJCdvXW7wuIi9/xCRASNJjBblEuE9WIcGBHd0qJdmaJFGYw0kDykEhhoWAx4 1aX3ENh7tlg1rP21oKtiith/YQvzsvg0hyJYIawExXlg//USRiX97bN4ljwyz4Gdrwgz fqPxmdMFdn32/NqV+7ijfDeIXxraVZI822+klJq1HO9aGFoC2dR5TZt6tURfBIC5PrKL 6g4ESfLx6urKbYrTppxPrCNoNdnIZF4Wvbfgf78rulYbpt284jqPnNPVY20y6BnINEOU D9q7ari83eaxwq1spFbXvx6ZjvWv82WJCttTllEtEKlsZr3lOtwcw3jiXR9ZGN2M57y5 rIyQ== X-Gm-Message-State: APjAAAVjwx9CYCbAqHYqWNR1yqViSLcTmKOp2k+rU6oA9ZHYBi4UHlVC tmvioLzc+/sP1mmQu0SkI88utUIFr8hC8nwS9cCrsTJ8tHQ= X-Google-Smtp-Source: APXvYqz7STa0GhXBuv37CxaMlNoq43HSVK3WYk++byqkEaXAWiijIrQq1mClS9XPRliv2KvWMhEDAZD42FaWuKZ5UDQ= X-Received: by 2002:a6b:7a42:: with SMTP id k2mr2503994iop.303.1568773606160; Tue, 17 Sep 2019 19:26:46 -0700 (PDT) MIME-Version: 1.0 References: <201909091232.x89CWl4b047025@donotpassgo.dyslexicfish.net> <27AD43DA-3237-490A-B3A6-C1792F9674E5@netflix.com> <5B630235-ABC7-4122-9082-F59BCCCDE14A@netflix.com> In-Reply-To: <5B630235-ABC7-4122-9082-F59BCCCDE14A@netflix.com> From: vm finance Date: Tue, 17 Sep 2019 19:26:34 -0700 Message-ID: Subject: Re: BBR patches? To: Randall Stewart Cc: Jamie Landeg-Jones , Ryan Stone , freebsd-net X-Rspamd-Queue-Id: 46Y3lC63K3z3DS9 X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=cuyxfh1U; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of vmfinance2@gmail.com designates 2607:f8b0:4864:20::d43 as permitted sender) smtp.mailfrom=vmfinance2@gmail.com X-Spamd-Result: default: False [-1.00 / 15.00]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; URI_COUNT_ODD(1.00)[15]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; SUBJECT_ENDS_QUESTION(1.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[3.4.d.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; IP_SCORE(0.00)[ip: (2.08), ipnet: 2607:f8b0::/32(-2.69), asn: 15169(-2.23), country: US(-0.05)]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Sep 2019 02:26:48 -0000 Hi Randall, Could you please provide a pointer to the latest patch. I had applied the one you published Sep-10. Following is what I have done: 1. Picked FreeBSD 12.0 RELEASE VM from osboxes.org 2. Got VM up under VMPlayer on x86 laptop 3. Checked out latest codebase from freebsd repo: svn co svn://svn.freebsd.org/base/head /usr/src* cd /usr/src; make buildworld buildkernel [this is where make fails when patch is applied] I could try to build with your latest patch - please send me a pointer. Thanks for your help! On Tue, Sep 17, 2019 at 1:33 PM Randall Stewart wrote: > Looking at your make file log I can=E2=80=99t really tell what you are do= ing. > > Its not the BBR or Rack code that is blowing up=E2=80=A6 > > Are you cross compiling? > > I have done the old fashioned kernel make > > i.e. > > cd src/sys/amd64/config > config headvm > cd ../compile/headvm > > make cleandepend ; make depend; make -j3 > > I have done > > cd src > make buildkernel KERNCONF=3Dheadvm > > And even > > make buildkernel KERNCONF=3DGENERIC > > to make sure that the build works without bbr. > > I attach my headvm config.. > > What exactly are you building and how? kernel config too please? > > R > > > > > > On Sep 17, 2019, at 1:11 PM, Randall Stewart wrote: > > > > looking > > > > I was at 352408.. let me update and try it > > > > R > > > >> On Sep 17, 2019, at 1:10 PM, Randall Stewart wrote: > >> > >> Hmm > >> > >> Did you get the patch I updated too this am? > >> > >> I have built it both with and without the bbr stack and had no issue.. > there was > >> an issue with KTLS before the update though. > >> > >> I don=E2=80=99t recognize what you have below there though=E2=80=A6 > >> > >> R > >> > >>> On Sep 17, 2019, at 11:47 AM, vm finance > wrote: > >>> > >>> Got it - thank you! > >>> > >>> btw, I tried to build the patch but its giving an error. Following is > SVN info + make error mesg. > >>> > >>> Please let me know what am I missing here? > >>> > >>> Thanks! > >>> > >>> #svnlite revision > >>> Path: . > >>> Working Copy Root Path: /usr/src > >>> URL: svn://svn.freebsd.org/base/head > >>> Relative URL: ^/head > >>> Repository Root: svn://svn.freebsd.org/base > >>> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f > >>> Revision: 352436 > >>> Node Kind: directory > >>> Schedule: normal > >>> Last Changed Author: jah > >>> Last Changed Rev: 352434 > >>> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019) > >>> > >>> root@osboxes:/usr/src # > >>> > >>> -------------------------------------------- snip > ---------------------------- > >>> > >>> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo > dev_net.llo bcache.llo interp_simple.llo zfs_cmd.llo > >>> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS > >>> =3D=3D=3D> sys (cleandir) > >>> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o > sack_filter.o rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h > opt_tcpdebug.h opt_kern_tls.h > >>> rm: x86: is a directory > >>> *** Error code 1 > >>> > >>> Stop. > >>> make[3]: stopped in /usr/src/sys > >>> *** Error code 1 > >>> > >>> Stop. > >>> make[2]: stopped in /usr/src > >>> *** Error code 1 > >>> > >>> Stop. > >>> make[1]: stopped in /usr/src > >>> *** Error code 1 > >>> > >>> Stop. > >>> make: stopped in /usr/src > >>> > >>> > >>> On Tue, Sep 17, 2019 at 6:41 PM vm finance > wrote: > >>> Got it - thank you! > >>> > >>> btw, I tried to build the patch but its giving an error. Following is > SVN info + make error mesg. > >>> I have also attached the entire build log...snippet is below > >>> > >>> Please let me know what am I missing here? > >>> > >>> Thanks! > >>> > >>> #svnlite revision > >>> Path: . > >>> Working Copy Root Path: /usr/src > >>> URL: svn://svn.freebsd.org/base/head > >>> Relative URL: ^/head > >>> Repository Root: svn://svn.freebsd.org/base > >>> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f > >>> Revision: 352436 > >>> Node Kind: directory > >>> Schedule: normal > >>> Last Changed Author: jah > >>> Last Changed Rev: 352434 > >>> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019) > >>> > >>> root@osboxes:/usr/src # > >>> > >>> -------------------------------------------- snip > ---------------------------- > >>> > >>> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo > dev_net.llo bcache.llo interp_simple.llo zfs_cmd.llo > >>> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS > >>> =3D=3D=3D> sys (cleandir) > >>> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o > sack_filter.o rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h > opt_tcpdebug.h opt_kern_tls.h > >>> rm: x86: is a directory > >>> *** Error code 1 > >>> > >>> Stop. > >>> make[3]: stopped in /usr/src/sys > >>> *** Error code 1 > >>> > >>> Stop. > >>> make[2]: stopped in /usr/src > >>> *** Error code 1 > >>> > >>> Stop. > >>> make[1]: stopped in /usr/src > >>> *** Error code 1 > >>> > >>> Stop. > >>> make: stopped in /usr/src > >>> > >>> > >>> On Tue, Sep 17, 2019 at 6:27 PM Randall Stewart > wrote: > >>> Pacing is provided by tcp_hpts.c. The current linux patches do not ha= ve > >>> to have fq.. they built an alternate means of doing pacing into bbr. > >>> > >>> In either case our testing has shown that our pacing is more accurate > than > >>> either fq or the internal pacer :) > >>> > >>> R > >>> > >>>> On Sep 17, 2019, at 11:05 AM, vm finance > wrote: > >>>> > >>>> Thanks Randall. > >>>> I was able to apply the patch - now rebuilding the kernel. Would > update on how it goes. > >>>> > >>>> BTW, is there any description on how lack of tc_fq under FreeBSD is > compensated here? > >>>> The original BBR patches on Linux show that as a must-have? Is that > functionality implemented via tcp_ratelimit.[ch]? > >>>> > >>>> Any pointers to existing presentations/discussions highly appreciate= d? > >>>> > >>>> Thanks a lot. > >>>> > >>>> On Tue, Sep 17, 2019 at 5:39 AM Randall Stewart > wrote: > >>>> You should be able to compile it against the current head. I re-doin= g > that now (had an > >>>> issue with my machine and had to roll it back to a backup). > >>>> > >>>> When I put the patch up on Sept 10th it complied with and without BB= R > on whatever > >>>> was that rev.. > >>>> > >>>> Looking in the commit logs that would have been around 352191 > >>>> > >>>> Hope that helps > >>>> > >>>> R > >>>> > >>>>> On Sep 17, 2019, at 3:32 AM, vm finance > wrote: > >>>>> > >>>>> Hi Randall, > >>>>> > >>>>> Thanks for releasing BBR patch: > >>>>> https://reviews.freebsd.org/D21582#change-xcAWBif3E9Jq > >>>>> > >>>>> Could you please let me know what SVN/GIT label tag this is based > on? I would like to patch and experiment with it. I couldn't find this in= fo > in the released patch. > >>>>> > >>>>> Thanks a lot! > >>>>> > >>>>> On Tue, Sep 10, 2019 at 10:26 AM Ryan Stone > wrote: > >>>>> rrs@ has just posted the BBR patch to phabricator: > >>>>> > >>>>> https://reviews.freebsd.org/D21582 > >>>> > >>>> ------ > >>>> Randall Stewart > >>>> rrs@netflix.com > >>>> > >>>> > >>>> > >>> > >>> ------ > >>> Randall Stewart > >>> rrs@netflix.com > >>> > >>> > >>> > >> > >> ------ > >> Randall Stewart > >> rrs@netflix.com > >> > >> > >> > > > > ------ > > Randall Stewart > > rrs@netflix.com > > > > > > > > ------ > Randall Stewart > rrs@netflix.com > > > >