Date: Wed, 24 Apr 2013 18:07:49 +0100 From: Chris Rees <crees@FreeBSD.org> To: Alex Dupre <ale@freebsd.org> Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, svn-ports-all@freebsd.org, "ports-committers@freebsd.org" <ports-committers@freebsd.org> Subject: Re: svn commit: r316439 - in head/databases: mysql55-server/files mysql56-server/files Message-ID: <CADLo839OtwHs4C%2BH35PYWuyaZNdSj2jFVjJXtj1B_uOT3Nn4Nw@mail.gmail.com> In-Reply-To: <201304241508.r3OF8MCT082012@svn.freebsd.org> References: <201304241508.r3OF8MCT082012@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 24 April 2013 16:08, Alex Dupre <ale@freebsd.org> wrote: > XXX Ports RC script present > XXX Ports RC script present > Author: ale > Date: Wed Apr 24 15:08:22 2013 > New Revision: 316439 > URL: http://svnweb.freebsd.org/changeset/ports/316439 > > Log: > Allow to specify server-specific option file path in /etc/rc.conf > > PR: ports/172408 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=172408 > Submitted by: Daniel Ylitalo <daniel@produktion203.se> > > Modified: > head/databases/mysql55-server/files/mysql-server.in > head/databases/mysql56-server/files/mysql-server.in > > Modified: head/databases/mysql55-server/files/mysql-server.in > ============================================================================== > --- head/databases/mysql55-server/files/mysql-server.in Wed Apr 24 14:21:12 2013 (r316438) > +++ head/databases/mysql55-server/files/mysql-server.in Wed Apr 24 15:08:22 2013 (r316439) > @@ -16,6 +16,8 @@ > # just before mysql starts. > # mysql_dbdir (str): Default to "/var/db/mysql" > # Base database directory. > +# mysql_optfile (str): Server-specific option file. > +# Default to "${mysql_dbdir}/my.cnf". > # mysql_pidfile (str): Custum PID file path and name. > # Default to "${mysql_dbdir}/${hostname}.pid". > # mysql_args (str): Custom additional arguments to be passed > @@ -32,12 +34,13 @@ load_rc_config $name > : ${mysql_enable="NO"} > : ${mysql_limits="NO"} > : ${mysql_dbdir="/var/db/mysql"} > +: ${mysql_optfile="${mysql_dbdir}/my.cnf"} > > mysql_user="mysql" > mysql_limits_args="-e -U ${mysql_user}" > pidfile=${mysql_pidfile:-"${mysql_dbdir}/`/bin/hostname`.pid"} This is fairly slow for executing every time the script is included, can I suggest replacing the preceding pidfile line with: : ${hostname:=`hostname`} pidfile=${mysql_pidfile:-"${mysql_dbdir}/${hostname}.pid"} ? The majority of users will have set hostname in rc.conf, so this means that the call to the hostname binary is redundant. Chris
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADLo839OtwHs4C%2BH35PYWuyaZNdSj2jFVjJXtj1B_uOT3Nn4Nw>