From owner-freebsd-net@FreeBSD.ORG Fri Dec 4 20:13:06 2009 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 11EAB106568B for ; Fri, 4 Dec 2009 20:13:06 +0000 (UTC) (envelope-from is@rambler-co.ru) Received: from mailrelay1.rambler.ru (mailrelay1.rambler.ru [81.19.66.239]) by mx1.freebsd.org (Postfix) with ESMTP id B95C68FC17 for ; Fri, 4 Dec 2009 20:13:05 +0000 (UTC) Received: from kas30pipe.localhost (localhost [127.0.0.1]) by mailrelay1.rambler.ru (Postfix) with ESMTP id 1A3F4130C26 for ; Fri, 4 Dec 2009 23:13:04 +0300 (MSK) Received: from localhost (sysoev.ru [81.19.68.137]) by mailrelay1.rambler.ru (Postfix) with ESMTP id 95375130C1F for ; Fri, 4 Dec 2009 23:13:03 +0300 (MSK) Date: Fri, 4 Dec 2009 23:13:03 +0300 From: Igor Sysoev To: freebsd-net@freebsd.org Message-ID: <20091204201303.GD76992@rambler-co.ru> References: <20091204075440.GH14822@rambler-co.ru> <20091204173243.GC16491@michelle.cdnetworks.com> <20091204191114.GB76992@rambler-co.ru> <20091204195140.GH16491@michelle.cdnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <20091204195140.GH16491@michelle.cdnetworks.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-Anti-Virus: Kaspersky Anti-Virus for MailServers 5.5.33/RELEASE, bases: 02092009 #2738642, status: clean X-SpamTest-Envelope-From: is@rambler-co.ru X-SpamTest-Group-ID: 00000000 X-SpamTest-Info: Profiles 9536 [Sen 02 2009] X-SpamTest-Info: {HEADERS: header Content-Type found without required header Content-Transfer-Encoding} X-SpamTest-Method: none X-SpamTest-Rate: 10 X-SpamTest-SPF: pass X-SpamTest-Status: Not detected X-SpamTest-Status-Extended: not_detected X-SpamTest-Version: SMTP-Filter Version 3.0.0 [0284], KAS30/Release Subject: Re: hw.bge.forced_collapse X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Dec 2009 20:13:06 -0000 On Fri, Dec 04, 2009 at 11:51:40AM -0800, Pyun YongHyeon wrote: > On Fri, Dec 04, 2009 at 10:11:14PM +0300, Igor Sysoev wrote: > > On Fri, Dec 04, 2009 at 09:32:43AM -0800, Pyun YongHyeon wrote: > > > > > On Fri, Dec 04, 2009 at 10:54:40AM +0300, Igor Sysoev wrote: > > > > I saw commit introducing hw.bge.forced_collapse loader tunable. > > > > Just intresting, why it can not be a sysctl ? > > > > > > I didn't think the sysctl variable would be frequently changed > > > in runtime except debugging driver so I took simple path. > > > > I do not think it's worth to reboot server just to look how various > > values affect on bandwidth and CPU usage, expecially in production. > > > > As I understand the change is trivial: > > > > - CTLFLAG_RD > > + CTLFLAG_RW > > > > since bge_forced_collapse is used atomically. > > > > I have no problem changing it to RW but that case I may have to > create actual sysctl node(e.g. dev.bge.0.forced_collapse) instead > of hw.bge.forced_collapse which may affect all bge(4) controllers > on system. Attached patch may be what you want. You can change the > value at any time. Thank you for the patch. Can it be installed on 8-STABLE ? -- Igor Sysoev http://sysoev.ru/en/