From owner-svn-ports-head@FreeBSD.ORG Thu Jul 11 11:42:25 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id A9B5B941; Thu, 11 Jul 2013 11:42:25 +0000 (UTC) (envelope-from william88@gmail.com) Received: from mail-lb0-x22c.google.com (mail-lb0-x22c.google.com [IPv6:2a00:1450:4010:c04::22c]) by mx1.freebsd.org (Postfix) with ESMTP id 6DEC71691; Thu, 11 Jul 2013 11:42:24 +0000 (UTC) Received: by mail-lb0-f172.google.com with SMTP id v20so6705927lbc.31 for ; Thu, 11 Jul 2013 04:42:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=VWm7bxxwWyFG0j2boH/Sq9QJdtEf0jGmjaeJvFRqdjs=; b=X2sLqFYpdXaazlyDDehmUSODHkWhEVhumcwCpQ1mTCx/Crv3jW7CsDl+EhvakJ+1BG 4V8lA3vAA802UQDbSDh8PDN6HuJMUkUwH3dmhsLnKDym8CSyArz5WpvAi0GxyvpXNCsd G8SOoTk2q1JLfor+/90zADKqcffwiifkMVQdozkKBH/X6XLVH824eWeng3c+pgwcyzQq cMIGcx2SVsTUhaYzosxSHfYANr0R/dDuV7s/PFymfX0JDJw+Aab8xq0Yi/JcOzJfIHjV oK6vBvsqMqhv8j7WHcQWFrSZLRN9c4gRW/EFGflQYg94aPS4Z7GAikTTJAEL5dpYSk+k l4bg== MIME-Version: 1.0 X-Received: by 10.112.28.48 with SMTP id y16mr17344650lbg.37.1373542943413; Thu, 11 Jul 2013 04:42:23 -0700 (PDT) Received: by 10.114.91.164 with HTTP; Thu, 11 Jul 2013 04:42:23 -0700 (PDT) In-Reply-To: <20130711054533.GA70334@FreeBSD.org> References: <201307101754.r6AHshZl027414@svn.freebsd.org> <20130711054533.GA70334@FreeBSD.org> Date: Thu, 11 Jul 2013 08:42:23 -0300 Message-ID: Subject: Re: svn commit: r322724 - head/net-p2p/qbittorrent From: William Grzybowski To: Alexey Dokuchaev Content-Type: text/plain; charset=ISO-8859-1 Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, William Grzybowski , ports-committers X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Jul 2013 11:42:25 -0000 On Thu, Jul 11, 2013 at 2:45 AM, Alexey Dokuchaev wrote: > On Wed, Jul 10, 2013 at 05:54:43PM +0000, William Grzybowski wrote: >> New Revision: 322724 >> URL: http://svnweb.freebsd.org/changeset/ports/322724 >> >> @@ -43,7 +46,7 @@ CONFIGURE_ARGS+= --disable-qt-dbus >> .endif >> >> post-patch: >> - @${REINPLACE_CMD} -e 's,qputenv,!&,' ${WRKSRC}/src/main.cpp >> + @${REINPLACE_CMD} -e 's|qputenv|!&|' ${WRKSRC}/src/main.cpp > > There are two problems with this part: > > 1) It gratuitously changes perfectly fine commas to (also perfectly fine > as it might seem) bars. Gratuitous commits should generally be avoided, as > they decrease STN ratio, and most importantly, they break 'svn blame'; > > 2) Prior to this commit, 'svn blame' would have shown that this line was > added by me in r307714, to suppress bogus warning on startup of qBittorrent. > I've reported this bug to upstream [1] roughly 8 months ago, and it was > subsequently fixed. If you would have carefully checked this (like you've > should), you would have realized that this post-patch: gimmick should just > be removed now, instead of essentially putting the bug back: > > // Set environment variable > if (!!qputenv("QBITTORRENT", QByteArray(VERSION))) { > std::cerr << "Couldn't set environment variable...\n"; > } > > This is how the code now looks after "make patch". That said, when becoming > a maintainer, it is very much advised to study how a port was maintained in > the past, what had been done on it, and for what reasons. Confirming with > upstream goes without saying. Thank you. It would make everyones life easier if you had put a comment in the post-patch line about that fact. Thank you. -- William Grzybowski ------------------------------------------ Curitiba/PR - Brasil