Date: Fri, 30 Nov 2018 12:17:52 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 233662] graphics/djvulibre: Take MAINTAINER'ship Message-ID: <bug-233662-7788-Fkrme9zdVW@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-233662-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-233662-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D233662 --- Comment #1 from Tobias Kortkamp <tobik@freebsd.org> --- (In reply to Lorenzo Salvadore from comment #0) > Cleans the header of the Makefile from the deprecated line "Created > by". It is not deprecated, adding new "Created by" lines is only discouraged. You cannot just change/remove "Created by" headers that you yourself did not add without approval of the original creator, so leave it in or ask mi@ for permission. > Changes a CONFIGURE_ARGS=3D --with... in a CONFIGURE_WITH=3D ... There is no CONFIGURE_WITH variable (there are opt_CONFIGURE_WITH helpers for options only), so this is wrong... How was this tested? Compare `make -V CONFIGURE_ARGS` before and after this change. Using LOCALBASE in this context is wrong too. LOCALBASE is where dependencies come from, PREFIX is where the port installs files into, so it should stay as PREFIX. But passing --with-pkgconfigdir to configure is probably no longer needed anyway due to recent framework changes and fixup-lib-pkgconfig. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-233662-7788-Fkrme9zdVW>