Date: Sun, 13 Dec 2009 14:40:04 GMT From: Graham Todd <gtodd@bellanet.org> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/141188: sysutils/freebsd-snapshot does not report all errors Message-ID: <200912131440.nBDEe4vF061486@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/141188; it has been noted by GNATS. From: Graham Todd <gtodd@bellanet.org> To: "Ralf S. Engelschall" <rse@FreeBSD.org>, bug-followup@FreeBSD.org Cc: Subject: Re: ports/141188: sysutils/freebsd-snapshot does not report all errors Date: Sun, 13 Dec 2009 09:35:27 -0500 Ralf S. Engelschall wrote: >> Edwin Groothuis wrote: >>> Maintainer of sysutils/freebsd-snapshot, >>> >>> Please note that PR ports/141188 has just been submitted. >>> >>> If it contains a patch for an upgrade, an enhancement or a bug fix >>> you agree on, reply to this email stating that you approve the patch >>> and a committer will take care of it. >>> >>> The full text of the PR can be found at: >>> http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/141188 > > Attention: the patch has a bug in its last chunk: it checks for $? after > the "time_end=`date '+%s'`" command and this way does not check the > possible failure of "snapshot make -g$when $fs:$time_tag.0" but of the > "date" command. > > I've fixed this bug and have taken over the other changes into the > latest version of my snapshot utilities. Find the new version on > http://people.freebsd.org/~rse/dist/ Thanks! With the latest patch to the port everything has been fixed upstream.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200912131440.nBDEe4vF061486>