Date: Sun, 28 Jul 2019 18:11:02 +0200 From: Niclas Zeising <zeising+freebsd@daemonic.se> To: Alan Somers <asomers@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r350390 - head/sys/kern Message-ID: <a5096797-5a6e-46ca-af28-fc4ebfd29dbc@daemonic.se> In-Reply-To: <201907281607.x6SG7SV3080649@repo.freebsd.org> References: <201907281607.x6SG7SV3080649@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2019-07-28 18:07, Alan Somers wrote: > Author: asomers > Date: Sun Jul 28 16:07:27 2019 > New Revision: 350390 > URL: https://svnweb.freebsd.org/changeset/base/350390 > > Log: > Better comments for vlrureclaim > > MFC after: 2 weeks > Sponsored by: The FreeBSD Foundation > > Modified: > head/sys/kern/vfs_subr.c > > Modified: head/sys/kern/vfs_subr.c > ============================================================================== > --- head/sys/kern/vfs_subr.c Sun Jul 28 15:20:47 2019 (r350389) > +++ head/sys/kern/vfs_subr.c Sun Jul 28 16:07:27 2019 (r350390) > @@ -947,9 +947,16 @@ vattr_null(struct vattr *vap) > * desirable to reuse such vnodes. These conditions may cause the > * number of vnodes to reach some minimum value regardless of what > * you set kern.maxvnodes to. Do not set kern.maxvnodes too low. > + * > + * @param mp Try to reclaim vnodes from this mountpoint > + * @param reclaim_nc_src Only reclaim directories with outgoing namecache > + * entries if this argument is strue > + * @param trigger Only reclaim vnodes with fewer than this many resident > + * pages. > + * @return The number of vnodes that were reclaimed. > */ > static int > -vlrureclaim(struct mount *mp, int reclaim_nc_src, int trigger) > +vlrureclaim(struct mount *mp, bool reclaim_nc_src, int trigger) > { > struct vnode *vp; > int count, done, target; > @@ -1238,7 +1245,8 @@ vnlru_proc(void) > { > struct mount *mp, *nmp; > unsigned long onumvnodes; > - int done, force, reclaim_nc_src, trigger, usevnodes; > + int done, force, trigger, usevnodes; > + bool reclaim_nc_src; > > EVENTHANDLER_REGISTER(shutdown_pre_sync, kproc_shutdown, vnlruproc, > SHUTDOWN_PRI_FIRST); Was this change intended? It's not mentioned in the commit message. Thanks! Regards -- Niclas
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?a5096797-5a6e-46ca-af28-fc4ebfd29dbc>