Date: Fri, 13 May 2011 17:26:28 +0200 From: Henrik Brix Andersen <brix@FreeBSD.org> To: John Baldwin <jhb@freebsd.org> Cc: freebsd-drivers@freebsd.org Subject: Re: Allocating resources to isab children Message-ID: <501C355E-0107-4185-8B47-C6D55ED71CB2@FreeBSD.org> In-Reply-To: <4DCC8C27.2010605@FreeBSD.org> References: <3550EA55-ADDE-40AC-9C22-1FAC441A0BC8@freebsd.org> <0A707516-C7D1-4441-B17B-1273B6C256B0@FreeBSD.org> <A5AEBC94-8E50-49E0-A72E-9B9E8A73E7F6@FreeBSD.org> <201103141028.57324.jhb@freebsd.org> <87F8ACF6-822B-41E3-B832-890F7F68ABA2@FreeBSD.org> <4DCC8C27.2010605@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --Apple-Mail-6-575674460 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On May 13, 2011, at 03:40, John Baldwin wrote: > On 5/12/11 5:45 PM, Henrik Brix Andersen wrote: >>=20 >> Having completed the driver for the I2C host bus controller, I have = revised the patch a little. >> The updated patch is available at = http://people.freebsd.org/~brix/src-patches/isa_pci.c.diff >=20 > A few cosmetic nits: >=20 > - I would use 'isab_pci_*' rather than 'isa_pci_*' as it is an ISA = bridge rather than an ISA bus device. > - You can probably leave out the blank line in isa[b]_pci_attach() = between bus_generic_probe() and isab_attach(). >=20 > Other than that, you are fine to commit this with a reviewed by from = me. Thank you, committed with the changes suggested above. >> I would appreciate it if you could find the time to review this and - = if possible - approve a commit of this patch. >>=20 >> The patch for the glxiic(4) I2C host bus driver is available at = http://people.freebsd.org/~brix/src-patches/glxiic.diff - if somebody = could find the time to review this as well, I would be very grateful. = Since I do not have a commit bit for src, I will eventually need an = approval for this to enter the tree as well. >=20 > This mostly looks good to me. I can't evaluate the actual driver = logic, but the new-bus, etc. bits look fine. One thing is that since = you use callout_init_mtx(), I don't think you need any of the callout = stuff at the start of your timeout routine = (callout_pending/active/deactivate). With callout_init_mtx() your = callout will only be called if it is active. That is the only nit that = I saw however. Ah, right - thanks. I have updated the patch and retested without = issues. Since it seems we lack an official iicbus(4) maintainer (?), perhaps I = should post this patch on the freebsd-embedded@ mailing list for review = (as the CS5536 and I2C are often found in combination on SBCs such as = the Alix boards from PC Engines). Hopefully somebody will be able to = review the actual driver logic and provide approval. Regards, Brix --=20 Henrik Brix Andersen <brix@FreeBSD.org> --Apple-Mail-6-575674460 content-type: application/pgp-signature; x-mac-type=70674453; name=PGP.sig content-description: This is a digitally signed message part content-disposition: inline; filename=PGP.sig content-transfer-encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (Darwin) iEYEARECAAYFAk3NTaQACgkQv+Q4flTiePjSxgCgswUS5A7yE+/aJW4dsp+r/VyL ZPIAoMb53dYbCd5jBQBxppaVuJgE88Tj =6mo8 -----END PGP SIGNATURE----- --Apple-Mail-6-575674460--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?501C355E-0107-4185-8B47-C6D55ED71CB2>