From owner-p4-projects@FreeBSD.ORG Tue Apr 3 19:13:15 2012 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 5E8591065674; Tue, 3 Apr 2012 19:13:15 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 20EF3106566C for ; Tue, 3 Apr 2012 19:13:15 +0000 (UTC) (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Received: from skunkworks.freebsd.org (skunkworks.freebsd.org [IPv6:2001:4f8:fff6::2d]) by mx1.freebsd.org (Postfix) with ESMTP id 0935F8FC18 for ; Tue, 3 Apr 2012 19:13:15 +0000 (UTC) Received: from skunkworks.freebsd.org (localhost [127.0.0.1]) by skunkworks.freebsd.org (8.14.4/8.14.4) with ESMTP id q33JDEjP097396 for ; Tue, 3 Apr 2012 19:13:14 GMT (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Received: (from perforce@localhost) by skunkworks.freebsd.org (8.14.4/8.14.4/Submit) id q33JDEZW097393 for perforce@freebsd.org; Tue, 3 Apr 2012 19:13:14 GMT (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Date: Tue, 3 Apr 2012 19:13:14 GMT Message-Id: <201204031913.q33JDEZW097393@skunkworks.freebsd.org> X-Authentication-Warning: skunkworks.freebsd.org: perforce set sender to bb+lists.freebsd.perforce@cyrus.watson.org using -f From: Robert Watson To: Perforce Change Reviews Precedence: bulk Cc: Subject: PERFORCE change 209029 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Apr 2012 19:13:15 -0000 http://p4web.freebsd.org/@@209029?ac=10 Change 209029 by rwatson@rwatson_svr_ctsrd_mipsbuild on 2012/04/03 19:12:10 Remove a KASSERT documenting a non-invariant of bp->bio_resid in the Altera SD Card IP core. An earlier iteration depended on this invariant but the current one doesn't, so functional change other than fewer assertion failures. Affected files ... .. //depot/projects/ctsrd/beribsd/src/sys/dev/altera/sdcard/altera_sdcard_io.c#4 edit Differences ... ==== //depot/projects/ctsrd/beribsd/src/sys/dev/altera/sdcard/altera_sdcard_io.c#4 (text+ko) ==== @@ -217,8 +217,6 @@ * SD Card IP Core sector size. Catch any attempts to not follow the * rules. */ - KASSERT(bp->bio_bcount == bp->bio_resid, - ("%s: bcount != resid", __func__)); KASSERT(bp->bio_bcount == ALTERA_SDCARD_SECTORSIZE, ("%s: I/O size not %d", __func__, ALTERA_SDCARD_SECTORSIZE));