From owner-svn-ports-all@freebsd.org  Wed Sep 14 08:52:49 2016
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2F111BDA6FD;
 Wed, 14 Sep 2016 08:52:49 +0000 (UTC)
 (envelope-from mike@reifenberger.com)
Received: from mail.eeeit.de (mail.eeeit.de [37.120.160.187])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id ED4F3B01;
 Wed, 14 Sep 2016 08:52:48 +0000 (UTC)
 (envelope-from mike@reifenberger.com)
Received: from localhost (localhost [127.0.0.1])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 (Authenticated sender: mike@reifenberger.com)
 by mail.eeeit.de (Postfix) with ESMTPSA id 671995D04;
 Wed, 14 Sep 2016 10:52:45 +0200 (CEST)
Received: from ppp-62-216-197-106.dynamic.mnet-online.de
 (ppp-62-216-197-106.dynamic.mnet-online.de [62.216.197.106]) by
 mail.eeeit.de (Horde Framework) with HTTPS; Wed, 14 Sep 2016 10:52:45 +0200
Date: Wed, 14 Sep 2016 10:52:45 +0200
Message-ID: <20160914105245.Horde.cp5oX9evYBLUL3LRGKjxK-b@mail.eeeit.de>
From: Michael Reifenberger <mike@reifenberger.com>
To: Mathieu Arnold <mat@freebsd.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r422061 - in head/comms/uhd: . files
References: <201609131858.u8DIwelq007807@repo.freebsd.org>
 <2fc3d1fd-f23a-e895-6595-f2cfda0967ff@FreeBSD.org>
In-Reply-To: <2fc3d1fd-f23a-e895-6595-f2cfda0967ff@FreeBSD.org>
User-Agent: Horde Application Framework 5
Content-Type: text/plain; charset=utf-8; format=flowed; DelSp=Yes
MIME-Version: 1.0
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Sep 2016 08:52:49 -0000

Hi,

first a big thanks for your hints and suggestions!

Zitat von Mathieu Arnold <mat@freebsd.org>:

> Le 13/09/2016 à 20:58, Michael Reifenberger a écrit :
>> +EXTRACT_ONLY=	${DISTFILES}
>
> That is not needed, it is the default.
>
>> +GH_TAGNAME=     ${UHD_COMMIT}
>> +
>> +UHD_COMMIT=	32951af2f3e7b1ddb56486c9f15b2e1033605bd6
>

Merged.

> I'm not sure using a second variable only once is needed.
>
>> +COMPILER_FEATURES=	libc++
>

Deleted.

> That variable is *read-only*, writing to it makes no sense.
>
>> +MAKE_JOBS_UNSAFE=	yes
>

Deleted. Seems to be unnecessary.

> When adding MAKE_JOBS_UNSAFE, you have to say why it does not build with
> make -j.
>
>> +DOCSDIR=	share/doc/uhd
>
> This is the default and not needed.
>
>> +.if ${OSVERSION} < 800000
>> +IGNORE=	needs libusb 1.0
>> +.endif
>
> Adding that OSVERSION check makes no sense, no release before 9 will
> work with the current ports tree.
>

Deleted.

>> +.if ${PORT_OPTIONS:MDOCS}
>> +BUILD_DEPENDS+=	doxygen:${PORTSDIR}/devel/doxygen
>> +CMAKE_ARGS+=	-DENABLE_DOXYGEN:STRING="ON"
>> +HAVEDOCS=	YES
>> +.endif
>
> Do not add doxygen as a dependency with a DOCS option, use a DOXYGEN one.
>

You mean like this:

.if ${PORT_OPTIONS:MDOXYGEN}
...
.endif

>> +-    DESTINATION ${LIBRARY_DIR}/pkgconfig
>> ++    DESTINATION libdata/pkgconfig
>
> This is handled by USES=pathfix.
>

Done.


>
> --
> Mathieu Arnold

Again, thanks alot for your tips!

Greetings
---
mike

Gruß
---
Michael Reifenberger