From owner-freebsd-ports-bugs@FreeBSD.ORG Fri Jun 1 11:10:06 2007 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0D19516A474 for ; Fri, 1 Jun 2007 11:10:06 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id D501413C4C4 for ; Fri, 1 Jun 2007 11:10:05 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l51BA5S6005081 for ; Fri, 1 Jun 2007 11:10:05 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l51BA5tu005080; Fri, 1 Jun 2007 11:10:05 GMT (envelope-from gnats) Resent-Date: Fri, 1 Jun 2007 11:10:05 GMT Resent-Message-Id: <200706011110.l51BA5tu005080@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Thomas Spreng Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4385816A421; Fri, 1 Jun 2007 11:02:58 +0000 (UTC) (envelope-from root@idspreng.unibe.ch) Received: from mailhub-lb3.unibe.ch (mailhub-lb3.unibe.ch [130.92.0.84]) by mx1.freebsd.org (Postfix) with ESMTP id CCA3813C45B; Fri, 1 Jun 2007 11:02:57 +0000 (UTC) (envelope-from root@idspreng.unibe.ch) Received: from localhost (scanhub02.unibe.ch [130.92.5.62]) by mailhub-lb3.unibe.ch (Postfix) with ESMTP id CA22BC4306; Fri, 1 Jun 2007 12:47:42 +0200 (CEST) Received: from mailhub-lb3.unibe.ch ([130.92.0.84]) by localhost (scanhub02.unibe.ch [130.92.5.62]) (amavisd-new, port 10024) with LMTP id BBiMebmqmXsu; Fri, 1 Jun 2007 12:47:38 +0200 (CEST) Received: from hotpot (hotpot.unibe.ch [130.92.7.70]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mailhub-lb3.unibe.ch (Postfix) with ESMTP id 2A1C2C41D1; Fri, 1 Jun 2007 12:47:39 +0200 (CEST) Received: from idspreng.unibe.ch (idspreng.unibe.ch [130.92.7.175]) by hotpot (Postfix) with ESMTP id E578614A40A8; Fri, 1 Jun 2007 12:47:38 +0200 (CEST) Received: from idspreng.unibe.ch (localhost [127.0.0.1]) by idspreng.unibe.ch (8.13.8/8.13.8) with ESMTP id l51Am5ZP091719; Fri, 1 Jun 2007 12:48:05 +0200 (CEST) (envelope-from root@idspreng.unibe.ch) Received: (from root@localhost) by idspreng.unibe.ch (8.13.8/8.13.8/Submit) id l51Am52A091718; Fri, 1 Jun 2007 12:48:05 +0200 (CEST) (envelope-from root) Message-Id: <200706011048.l51Am52A091718@idspreng.unibe.ch> Date: Fri, 1 Jun 2007 12:48:05 +0200 (CEST) From: Thomas Spreng To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: obrien@FreeBSD.org Subject: ports/113216: [PATCH] net/rdesktop: fix segfault at login using xorg 7.2 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Thomas Spreng List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jun 2007 11:10:06 -0000 >Number: 113216 >Category: ports >Synopsis: [PATCH] net/rdesktop: fix segfault at login using xorg 7.2 >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: update >Submitter-Id: current-users >Arrival-Date: Fri Jun 01 11:10:03 GMT 2007 >Closed-Date: >Last-Modified: >Originator: Thomas Spreng >Release: FreeBSD 6.2-RELEASE i386 >Organization: >Environment: System: FreeBSD idspreng.unibe.ch 6.2-RELEASE FreeBSD 6.2-RELEASE #6: Mon Jan 15 14:27:45 CET 2007 toor@idspreng.unibe.ch:/usr/obj/usr/src/sys/IDSPRENG i386 >Description: rdesktop may segfault due to Xlib sanity checking of arguments passed to XCreateImage(3) if using xorg 7.2. This patch is based on a PR from Ubuntu concerning the same problem: https://bugs.launchpad.net/ubuntu/+source/rdesktop/+bug/104332 I've tested the patch with a connection to a Windows 2003 SP2 Terminal Server with all color depth's, fullscreen and window mode. >How-To-Repeat: Try to log into Windows 2003 SP2 (not sure about other versions) using rdesktop 1.5.0_1 and xorg 7.2. >Fix: --- rdesktop-1.5.0_2.diff begins here --- diff -ruN rdesktop.bak/Makefile rdesktop/Makefile --- rdesktop.bak/Makefile Sat May 19 22:18:54 2007 +++ rdesktop/Makefile Fri Jun 1 11:30:39 2007 @@ -7,7 +7,7 @@ PORTNAME= rdesktop PORTVERSION= 1.5.0 -PORTREVISION?= 1 +PORTREVISION?= 2 CATEGORIES= net comms MASTER_SITES= ${MASTER_SITE_SOURCEFORGE} MASTER_SITE_SUBDIR= ${PORTNAME} diff -ruN rdesktop.bak/files/patch-xwin.c rdesktop/files/patch-xwin.c --- rdesktop.bak/files/patch-xwin.c Thu Jan 1 01:00:00 1970 +++ rdesktop/files/patch-xwin.c Fri Jun 1 11:30:39 2007 @@ -0,0 +1,11 @@ +--- xwin.c.orig Fri Jun 1 10:27:15 2007 ++++ xwin.c Fri Jun 1 10:28:26 2007 +@@ -3219,7 +3219,7 @@ + return; + + image = XCreateImage(g_display, g_visual, g_depth, ZPixmap, 0, +- (char *) data, cx, cy, BitmapPad(g_display), cx * g_bpp / 8); ++ (char *) data, cx, cy, g_bpp, 0); + + if (g_ownbackstore) + { --- rdesktop-1.5.0_2.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: