From owner-freebsd-hackers Sun Oct 26 03:49:30 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.7/8.8.7) id DAA00933 for hackers-outgoing; Sun, 26 Oct 1997 03:49:30 -0800 (PST) (envelope-from owner-freebsd-hackers) Received: from rvc1.informatik.ba-stuttgart.de (rvc1.informatik.ba-stuttgart.de [141.31.112.22]) by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id DAA00927; Sun, 26 Oct 1997 03:49:23 -0800 (PST) (envelope-from helbig@Informatik.BA-Stuttgart.DE) Received: (from helbig@localhost) by rvc1.informatik.ba-stuttgart.de (8.8.7/8.8.5) id MAA07531; Sun, 26 Oct 1997 12:49:10 +0100 (MET) From: Wolfgang Helbig Message-Id: <199710261149.MAA07531@rvc1.informatik.ba-stuttgart.de> Subject: Re: cvs commit: src/gnu/usr.bin/diff system.h In-Reply-To: <199710230222.TAA07359@freefall.freebsd.org> from "Andrey A. Chernov" at "Oct 22, 97 07:22:52 pm" To: ache@FreeBSD.ORG (Andrey A. Chernov) Date: Sun, 26 Oct 1997 12:49:09 +0100 (MET) Cc: hackers@FreeBSD.ORG X-Mailer: ELM [version 2.4ME+ PL30 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-freebsd-hackers@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk > ache 1997/10/22 19:22:52 PDT > > Modified files: > gnu/usr.bin/diff system.h > Log: > Add (unsigned char) cast to ctype macros > > Revision Changes Path > 1.4 +5 -5 src/gnu/usr.bin/diff/system.h Should all char arguments to all ctype macros (isspace, isdigit ...) in our source tree be cast to unsigned char? Quite a lot of them aren't. Wolfgang