Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 8 Jan 2009 01:09:16 -0800
From:      "Jack Vogel" <jfvogel@gmail.com>
To:        "Yony Yossef" <yonyossef.lists@gmail.com>
Cc:        Eitan Shefi <eitans@mellanox.co.il>, Angelo Turetta <aturetta@bestunion.it>, Sam Leffler <sam@freebsd.org>, freebsd-net@freebsd.org
Subject:   Re: VLAN interface management - unloading carrying driver hangs the machine
Message-ID:  <2a41acea0901080109l6189b379q4a348cc80527e90e@mail.gmail.com>
In-Reply-To: <000601c97169$b85717b0$220f000a@mtl.com>
References:  <000001c970a8$3fa45240$220f000a@mtl.com> <4964C2E9.1060301@bestunion.it> <000001c970d9$4403e590$220f000a@mtl.com> <4964EC4F.8030507@freebsd.org> <2a41acea0901071359w3f41465ajb8206cdef5b7b680@mail.gmail.com> <49652E25.9030705@freebsd.org> <000601c97169$b85717b0$220f000a@mtl.com>

Next in thread | Previous in thread | Raw E-Mail | Index | Archive | Help
Fine with me, go do it and I'll take the driver code out :)

Jack


On Thu, Jan 8, 2009 at 12:18 AM, Yony Yossef <yonyossef.lists@gmail.com>wrote:

> > Jack Vogel wrote:
> > >
> > >
> > > On Wed, Jan 7, 2009 at 9:54 AM, Sam Leffler <sam@freebsd.org
> > > <mailto:sam@freebsd.org>> wrote:
> > >
> > >     Yony Yossef wrote:
> > >
> > >             Yony Yossef wrote:
> > >
> > >
> > >                 /sbin/ifconfig vlan3653 create
> > >
> > >                 Problem is when I assign an IP to the vlan
> > interface.
> > >                 In that case, unloading the driver results
> > in hanging
> > >                 the host.
> > >                  Does it sound familiar to anybody?
> > >
> > >
> > >             Well, surely I'd expect problems by doing so.
> > >             The correct way is to
> > >
> > >                    /sbin/ifconfig vlan3653 destroy
> > >
> > >             before unloading the driver.
> > >
> > >             Angelo.
> > >
> > >
> > >
> > >         Thanks, I didn't know freebsd does not allow it.
> > >
> > >
> > >
> > >     This seems wrong. Someone should disallow the driver
> > >     detach/unload. Please file a PR about this so the issue
> > is not lost.
> > >
> > >     Sam
> > >
> > >
> > > In many drivers, ahem, like mine, there is a test at detach and it
> > > will not allow it if there is a non-NULL trunk.
> > >
> > > Sounds like a broken driver needs to be fixed is all...
> > >
> > I don't agree; drivers should not be required to deal with
> > this.  If someone files a PR and assigns it to me I'll look at it.
> >
> >     Sam
> >
>
> I agree with Sam. There's no reason to leave this check to the driver.
>
> Yony
>
>



Want to link to this message? Use this URL: <http://docs.FreeBSD.org/cgi/mid.cgi?2a41acea0901080109l6189b379q4a348cc80527e90e>