From owner-freebsd-net@FreeBSD.ORG Thu Jan 8 09:09:17 2009 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 059F91065673; Thu, 8 Jan 2009 09:09:17 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: from wa-out-1112.google.com (wa-out-1112.google.com [209.85.146.181]) by mx1.freebsd.org (Postfix) with ESMTP id BE8878FC27; Thu, 8 Jan 2009 09:09:16 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: by wa-out-1112.google.com with SMTP id m34so4931314wag.27 for ; Thu, 08 Jan 2009 01:09:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type:references; bh=fcMlNiuwheoD8gzXxX7BHQryUVdfiS1SuKGaVBJVTPs=; b=RrwcwC4OCMYHIcZFrNdZPuh2eC0/ag88qE8qAtZcTvCKyje2leFHH5NwMJ17JjeUxq Bf0mMs576f7xsBXw++pcRVjmSFla1ygJTR2QL/0jywz3g+S23WmQV6wXpV28y6yQaKad MFyV6nF2zHCVhX4RAK0JL+K0jxo4zzTFx0v+I= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:references; b=a9UZ0c3jB0lCso2v0KZ/UzLQVI64FE7SgvjlONFmW160+fYCzZbdW7Axw6YFseTNas OlTdqQxwrjB/b9s063utykIhEQflPWXyIU1K9vFuPsb0+JhyRj9LRb3LlIPFQ211KmHO AOd6A8i25piOzLEfOrHeRicjkkKxQxKv570Bk= Received: by 10.115.92.2 with SMTP id u2mr15903142wal.228.1231405756193; Thu, 08 Jan 2009 01:09:16 -0800 (PST) Received: by 10.114.157.9 with HTTP; Thu, 8 Jan 2009 01:09:16 -0800 (PST) Message-ID: <2a41acea0901080109l6189b379q4a348cc80527e90e@mail.gmail.com> Date: Thu, 8 Jan 2009 01:09:16 -0800 From: "Jack Vogel" To: "Yony Yossef" In-Reply-To: <000601c97169$b85717b0$220f000a@mtl.com> MIME-Version: 1.0 References: <000001c970a8$3fa45240$220f000a@mtl.com> <4964C2E9.1060301@bestunion.it> <000001c970d9$4403e590$220f000a@mtl.com> <4964EC4F.8030507@freebsd.org> <2a41acea0901071359w3f41465ajb8206cdef5b7b680@mail.gmail.com> <49652E25.9030705@freebsd.org> <000601c97169$b85717b0$220f000a@mtl.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: Eitan Shefi , Angelo Turetta , Sam Leffler , freebsd-net@freebsd.org Subject: Re: VLAN interface management - unloading carrying driver hangs the machine X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Jan 2009 09:09:17 -0000 Fine with me, go do it and I'll take the driver code out :) Jack On Thu, Jan 8, 2009 at 12:18 AM, Yony Yossef wrote: > > Jack Vogel wrote: > > > > > > > > > On Wed, Jan 7, 2009 at 9:54 AM, Sam Leffler > > > wrote: > > > > > > Yony Yossef wrote: > > > > > > Yony Yossef wrote: > > > > > > > > > /sbin/ifconfig vlan3653 create > > > > > > Problem is when I assign an IP to the vlan > > interface. > > > In that case, unloading the driver results > > in hanging > > > the host. > > > Does it sound familiar to anybody? > > > > > > > > > Well, surely I'd expect problems by doing so. > > > The correct way is to > > > > > > /sbin/ifconfig vlan3653 destroy > > > > > > before unloading the driver. > > > > > > Angelo. > > > > > > > > > > > > Thanks, I didn't know freebsd does not allow it. > > > > > > > > > > > > This seems wrong. Someone should disallow the driver > > > detach/unload. Please file a PR about this so the issue > > is not lost. > > > > > > Sam > > > > > > > > > In many drivers, ahem, like mine, there is a test at detach and it > > > will not allow it if there is a non-NULL trunk. > > > > > > Sounds like a broken driver needs to be fixed is all... > > > > > I don't agree; drivers should not be required to deal with > > this. If someone files a PR and assigns it to me I'll look at it. > > > > Sam > > > > I agree with Sam. There's no reason to leave this check to the driver. > > Yony > >