From owner-cvs-all@FreeBSD.ORG Thu Mar 29 19:45:51 2007 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7F71416A40B; Thu, 29 Mar 2007 19:45:51 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.freebsd.org (Postfix) with ESMTP id 04B8C13C4B8; Thu, 29 Mar 2007 19:45:50 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l2TJjms3047358; Thu, 29 Mar 2007 14:45:48 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: Andrey Chernov Date: Thu, 29 Mar 2007 15:34:45 -0400 User-Agent: KMail/1.9.6 References: <200703291055.l2TAtYu4038445@repoman.freebsd.org> <20070329172409.GA38703@rogue.navcom.lan> <20070329190812.GA11138@nagual.pp.ru> In-Reply-To: <20070329190812.GA11138@nagual.pp.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200703291534.46417.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Thu, 29 Mar 2007 14:45:48 -0500 (EST) X-Virus-Scanned: ClamAV 0.88.3/2962/Thu Mar 29 13:39:44 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, Mike Makonnen , src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/etc network.subr X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Mar 2007 19:45:51 -0000 On Thursday 29 March 2007 03:08:12 pm Andrey Chernov wrote: > On Thu, Mar 29, 2007 at 08:24:09PM +0300, Mike Makonnen wrote: > > On Thu, Mar 29, 2007 at 10:55:34AM +0000, Andrey A. Chernov wrote: > > > ache 2007-03-29 10:55:34 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > etc network.subr > > > Log: > > > Fix get_if_var() with 3 args (i.e. with default) > > > > > > All xxx_ flags are set to empty strings automatically earlier so > > > eval echo \${${prefix}${_if}${suffix}-${_default}} > > > not substitute the default but return just the empty string. > > > Fix it using > > > eval echo \${${prefix}${_if}${suffix}:-${_default}} > > > (i.e. treat empty strings as unset) > > > > > > The bug manifistates itself with the following warning from checkyesno(): > > > /etc/rc.d/dhclient: WARNING: $background_dhclient is not set properly - > > > see rc.conf(5) > > > > > > Revision Changes Path > > > 1.178 +1 -1 src/etc/network.subr > > > > Please back this out. > > > > Your change doesn't fix the bug. It only hides it. The bug was fixed in > > rc.d/dhclient v1.28. > > No, the bug was not fixed. It IS in v1.28 The change in v1.28 fixed a similar warning where you'd get something like /etc/rc.d/dhclient: WARNING: $background_dhclient_bge0 is not set properly (where bge0 is an interface name). 1.28 fixed the warning for me, but I don't use background_dhclient and have none of the variables set. Maybe Andrey is seeing a warning in the non-default case when a variable is set? -- John Baldwin