From owner-freebsd-arch@FreeBSD.ORG Sat Apr 17 22:49:40 2010 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E8E8B1065672; Sat, 17 Apr 2010 22:49:40 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id A513D8FC26; Sat, 17 Apr 2010 22:49:40 +0000 (UTC) Received: from [127.0.0.1] (pooker.samsco.org [168.103.85.57]) (authenticated bits=0) by pooker.samsco.org (8.14.3/8.14.3) with ESMTP id o3HMnaBB041181; Sat, 17 Apr 2010 16:49:37 -0600 (MDT) (envelope-from scottl@samsco.org) Mime-Version: 1.0 (Apple Message framework v1078) Content-Type: text/plain; charset=us-ascii From: Scott Long In-Reply-To: <29917.1271406183@critter.freebsd.dk> Date: Sat, 17 Apr 2010 16:49:36 -0600 Content-Transfer-Encoding: quoted-printable Message-Id: References: <29917.1271406183@critter.freebsd.dk> To: Poul-Henning Kamp X-Mailer: Apple Mail (2.1078) X-Spam-Status: No, score=-1.0 required=3.8 tests=ALL_TRUSTED, T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.0 X-Spam-Checker-Version: SpamAssassin 3.3.0 (2010-01-18) on pooker.samsco.org Cc: Attilio Rao , Giovanni Trematerra , freebsd-arch@freebsd.org Subject: Re: [PATCH] Syncer rewriting X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Apr 2010 22:49:41 -0000 On Apr 16, 2010, at 2:23 AM, Poul-Henning Kamp wrote: >=20 >=20 >> - The standard syncer may be further improved getting rid of the >> bufobj. It should actually handle a list of vnodes rather than a list >> of bufobj. However similar optimizations may be done after the patch >> is ready to enter the tree. >=20 > That would be the wrong direction: we need the bufobj because for = instance > a RAID5 geom module does not have a vnode for the parity data. >=20 > If you force the syncer to only work on vnodes, then we need a = parallel > mechanism for non-filesystem disk users. It's been 5-6 (7?) years since you invented the bufobj, but I still = haven't seen anything in GEOM use it as you suggest. You used to have a saying about premature optimization... I'd like to see Attilio's work move forward = despite this. Scott