Date: Tue, 6 Mar 2007 13:17:45 +0100 From: Olivier Houchard <cognet@ci0.org> To: Sam Leffler <sam@errno.com> Cc: Jeff Roberson <jroberson@chesapeake.net>, src-committers@FreeBSD.org, "Wojciech A. Koszek" <wkoszek@FreeBSD.org>, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_alq.c Message-ID: <20070306121745.GB86528@ci0.org> In-Reply-To: <45ECE475.1010405@errno.com> References: <200703042340.l24Neanq039195@repoman.freebsd.org> <20070306234936.O635@10.0.0.1> <45ECE475.1010405@errno.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Mar 05, 2007 at 07:48:05PM -0800, Sam Leffler wrote: > Jeff Roberson wrote: > > The ALQ lock is a spinlock. I don't believe this works. Do I > > misunderstand something? > > > > On Sun, 4 Mar 2007, Wojciech A. Koszek wrote: > > > >> wkoszek 2007-03-04 23:40:36 UTC > >> > >> FreeBSD src repository > >> > >> Modified files: > >> sys/kern kern_alq.c > >> Log: > >> Use msleep(9) instead of tsleep(9) surrounded by lock acquisition and > >> release. > >> > >> Approved by: cognet (mentor) > >> > >> Revision Changes Path > >> 1.17 +2 -6 src/sys/kern/kern_alq.c > >> > > > > > > Yeah, this is totally busted and could never been tested. > That's my fault, sorry. Olivier
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070306121745.GB86528>