From owner-cvs-all@FreeBSD.ORG Fri May 28 10:45:34 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0FBA016A4E9 for ; Fri, 28 May 2004 10:45:34 -0700 (PDT) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id B513F43D49 for ; Fri, 28 May 2004 10:45:33 -0700 (PDT) (envelope-from scottl@freebsd.org) Received: from freebsd.org (junior-wifi.samsco.home [192.168.0.11]) (authenticated bits=0) by pooker.samsco.org (8.12.11/8.12.10) with ESMTP id i4SHp5T0088415; Fri, 28 May 2004 11:51:05 -0600 (MDT) (envelope-from scottl@freebsd.org) Message-ID: <40B77A6E.7000808@freebsd.org> Date: Fri, 28 May 2004 11:44:14 -0600 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.6) Gecko/20040304 X-Accept-Language: en-us, en MIME-Version: 1.0 To: John Baldwin References: <200405281340.47011.jhb@FreeBSD.org> In-Reply-To: <200405281340.47011.jhb@FreeBSD.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, hits=0.0 required=3.8 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on pooker.samsco.org cc: src-committers@freebsd.org cc: Mike Makonnen cc: cvs-src@freebsd.org cc: Daniel Eischen cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/sparc64/include atomic.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 May 2004 17:45:34 -0000 John Baldwin wrote: > On Friday 28 May 2004 04:38 am, Daniel Eischen wrote: > >>On Fri, 28 May 2004, Mike Makonnen wrote: >> >>>On Sat, May 22, 2004 at 02:58:06AM +0200, Marius Strobl wrote: >>> >>>>On Fri, May 21, 2004 at 05:52:16PM -0700, Marius Strobl wrote: >>>> >>>>>marius 2004/05/21 17:52:16 PDT >>>>> >>>>> FreeBSD src repository >>>>> >>>>> Modified files: >>>>> sys/sparc64/include atomic.h >>>>> Log: >>>>> Use unsigned types for the arguments of the atomic(9) operations, >>>>> like described in the man page and done on all other architectures. >>>> >>>>This fixes the current build problems of libthr on sparc64 but the >>>>libthr code shouldn't rely on the integer-type of enums. >>> >>>Thanks. I'll change those enums to integers soon (others have suggested >>>it as well). It's just that I find them so convenient when debugging. >> >>And the use of atomic_cmpset_foo() isn't going to work on >>80386 since it doesn't have cmpxchgl. >>will try to use cli instead. > > > I'd say just punt and suggest that 80386 machines use libc_r. > I think that this is a reasonable suggestion. libc_r likely has a longer lifespan than 80386 at this point (hard to believe that the 80386 has been out for nearly 20 years!). Scott