Date: Wed, 17 Jun 2015 19:14:08 -0600 From: Brad Davis <brd@FreeBSD.org> To: Steve Wills <swills@FreeBSD.org> Cc: Adam Weinberger <adamw@adamw.org>, Brad Davis <brd@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r389861 - in head/devel: cmake cmake-gui cmake-modules Message-ID: <20150618011408.GC94853@valentine.liquidneon.com> In-Reply-To: <20150617165030.GA48147@mouf.net> References: <201506162025.t5GKP6lx080770@svn.freebsd.org> <AD97DB22-EE1C-4779-A29F-EAEDA09E1E73@adamw.org> <20150617165030.GA48147@mouf.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jun 17, 2015 at 04:50:31PM +0000, Steve Wills wrote: > On Wed, Jun 17, 2015 at 09:39:11AM -0600, Adam Weinberger wrote: > > > On 16 Jun, 2015, at 14:25, Brad Davis <brd@FreeBSD.org> wrote: > > > > > > Author: brd > > > Date: Tue Jun 16 20:25:05 2015 > > > New Revision: 389861 > > > URL: https://svnweb.freebsd.org/changeset/ports/389861 > > > > > > Log: > > > Update devel/cmake, devel/cmake-gui and devel/cmake-modules to 3.2.3. > > > > > > Modified: head/devel/cmake/Makefile > > > ============================================================================== > > > > > > LIB_DEPENDS= libcurl.so:${PORTSDIR}/ftp/curl \ > > > - libexpat.so:${PORTSDIR}/textproc/expat2 > > > + libexpat.so:${PORTSDIR}/textproc/expat2 \ > > > + libjsoncpp.so:${PORTSDIR}/devel/jsoncpp > > > > Does this port really need to depend on libjsoncpp? The version bundled with cmake works just fine (--no-system-jsoncpp). > > > > The only benefit to making everybody install jsoncpp (and scons) would be if the jsoncpp port is updated more often than the cmake port. But the jsoncpp port hasn't had an update since the day it was added 16 months ago. > > > > Can you please consider dropping the libjsoncpp dependency and just adding --no-system-jsoncpp to CONFIGURE_ARGS? > > > > In general, it is better to not used bundled libs where possible. Let's update > the devel/jsoncpp port. I have a PR I need to commit for that.. :) https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200648 I don't care which we do.. If someone has a better reason.. Regards, Brad Davis
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150618011408.GC94853>