Date: Sun, 13 Jul 2014 15:30:50 +0100 From: Matthew Seaman <matthew@FreeBSD.org> To: Michelle Sullivan <michelle@sorbs.net>, Dmitry Sivachenko <demon@FreeBSD.org> Cc: ports@freebsd.org Subject: Re: Patch (not perfect but half way there) for DBIx::SearchBuilder... [Bug: 191734] Message-ID: <53C2981A.4020700@FreeBSD.org> In-Reply-To: <53C29217.3070307@sorbs.net> References: <53B4C581.5060508@sorbs.net> <53B4F7DE.9090300@FreeBSD.org> <53B67F53.9000903@sorbs.net> <53BBC5B9.60004@sorbs.net> <80A36579-08DC-4617-8180-8A2B142C0931@FreeBSD.org> <53BC067F.5080406@sorbs.net> <53BC5041.6080608@sorbs.net> <D4A0EE26-EC82-409D-A73E-476C0E1C2C5C@FreeBSD.org> <53C29217.3070307@sorbs.net>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --HGPssQLRMQCDcgEN7pvUvjtdC4erQx65o Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 13/07/2014 15:05, Michelle Sullivan wrote: > 1/ when would the new version be deployed to FreeBSD ports? (does it > need an update or is it automatic? - there might be a _02 or 1.66 patch= > soon) That's up to the port maintainer. Most active maintainers will pull in updates from upstream fairly promptly -- within a week or so. If not, then you can make it easy for them by putting in a PR with the diffs necessary to update the port. > 2/ is it possible (in my patch here) to only show the option if > particular databases are installed (for example for MySQL users the > patch makes little to no difference (except for the lag issues) - > however it potentially has a huge difference for Oracle and PostgreSQL > users.) In this case, no, not really. It's not considered correct for a port to behave differently depending on what else is installed -- or to put it in other words, it's the selected options that should be the only thing that affets the outcome of building the port. Remember too that a substantial amount of ports usage nowadays is by binary packages installed from clean-room builds: unless you'ld declared a dependency on some particular RDBMS, then you'ld either have no DB installed at all, or whatever the default DB was for every build. Of course, if you wanted to code the patch so that it could behave differently at run-time depending on what type of database it was being used with, that would be a different matter, and quite likely something you'ld have to persuade the upstream authors about. Cheers, Matthew --=20 Dr Matthew J Seaman MA, D.Phil. PGP: http://www.infracaninophile.co.uk/pgpkey --HGPssQLRMQCDcgEN7pvUvjtdC4erQx65o Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.20 (Darwin) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQJ8BAEBCgBmBQJTwpghXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ2NTNBNjhCOTEzQTRFNkNGM0UxRTEzMjZC QjIzQUY1MThFMUE0MDEzAAoJELsjr1GOGkATixwP/3M0/VTT9/umcGxglPLrSwlL 1aVd2KpnT0ixvb4qF5+6HvCwWwsdneyExLXAbCTO/KEVfR7epAwRcGmV68SfJfjS wRnwlF2dhz3hh6j4QQ31ugV6PKR+bMK6lKdCDkaUjTwn4pxYG1v3cdtFUaCBhc1j 1EmbR58P64Ju68APFKl/KhDjJ5gD0OWWpbDyinCNgIdT8XRgFZvV94Sb0NtC9vnv KnbX6l9JXphvsl4s2QwfGKGDi++ZE0RbgBGgNax+V/FXVcysNuHJszw6NzKzjvLQ rbksTfoA+1u5oB6G40uzDL9TaXws4PN9IVtc5RMfjbHbj2lxXW98/Xxi4kqf7wyS xkIU3/yLOkHYYPUYcAKOTKoTrOEddavj6Hl5de7kiFYJz7kBBHVax0iNE1AbCrbl rqrX5z1Hr0laJqN4YSBKK+i7AVk1END0ciYVyZsS1mF9a7PAoGR7uAWu76Fk3wVh ciAzLS0pAzGHiChGmmm7+0PNMrMthEXCfwraU0D5zKbfBaB+Sbf0OSIxwezH/yik 7veIZjgQjajzSU3A/8OTZwOiKaD5NdzkmjFsTy4MNmluBUKaJgir4ClkTp3h0Vrz NRECKqIo/2RPRWNrCj2CWFT/RBdSzZ3WQ/XF0gogu17Vslu5NFAcyUcaUzUyEVI3 C34CxGJSi1G4lr4syh4S =AwBl -----END PGP SIGNATURE----- --HGPssQLRMQCDcgEN7pvUvjtdC4erQx65o--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?53C2981A.4020700>