From owner-cvs-all@FreeBSD.ORG Thu Mar 29 20:39:19 2007 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id A931E16A401; Thu, 29 Mar 2007 20:39:19 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.freebsd.org (Postfix) with ESMTP id 38A1213C45A; Thu, 29 Mar 2007 20:39:19 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l2TKdGhE047740; Thu, 29 Mar 2007 15:39:16 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: Andrey Chernov Date: Thu, 29 Mar 2007 16:39:02 -0400 User-Agent: KMail/1.9.6 References: <200703291055.l2TAtYu4038445@repoman.freebsd.org> <200703291534.46417.jhb@freebsd.org> <20070329195857.GA11737@nagual.pp.ru> In-Reply-To: <20070329195857.GA11737@nagual.pp.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200703291639.03135.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Thu, 29 Mar 2007 15:39:16 -0500 (EST) X-Virus-Scanned: ClamAV 0.88.3/2962/Thu Mar 29 13:39:44 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, Mike Makonnen , src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/etc network.subr X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Mar 2007 20:39:19 -0000 On Thursday 29 March 2007 03:58:57 pm Andrey Chernov wrote: > On Thu, Mar 29, 2007 at 03:34:45PM -0400, John Baldwin wrote: > > The change in v1.28 fixed a similar warning where you'd get something like > > > > /etc/rc.d/dhclient: WARNING: $background_dhclient_bge0 is not set properly > > > > (where bge0 is an interface name). 1.28 fixed the warning for me, but I don't > > use background_dhclient and have none of the variables set. Maybe Andrey is > > seeing a warning in the non-default case when a variable is set? > > I have plain DHCP and don't use background_dhclient too. I wonder why > somebody have not see it. Look at this lines from v1.28: > > background_dhclient=`get_if_var $ifn background_dhclient_IF $background_dhclient` > if checkyesno background_dhclient; then > > Since background_dhclient_fxp0="" automatically set earlier, > background_dhclient evaluates to "" too. > Then checkyesno background_dhclient produces this warning. Where are you seeing background_dhclient_fxp0 being set? Oh, that's a bug in /etc/defaults/rc.conf I think. It shuoldn't have that entry set, or it should be set to either YES or NO, not empty. So, you have to have 'fxp0' to see this warning. The setting of 'dhclient_flags_fxp0' is also bogus. I think these are intended to be examples in which case they should be commented out like other examples in this file. I think this is the better fix, and that your network.subr change should be reverted: Index: rc.conf =================================================================== RCS file: /usr/cvs/src/etc/defaults/rc.conf,v retrieving revision 1.306 diff -u -r1.306 rc.conf --- rc.conf 6 Mar 2007 13:13:53 -0000 1.306 +++ rc.conf 29 Mar 2007 20:36:44 -0000 @@ -93,9 +93,9 @@ nisdomainname="NO" # Set to NIS domain if using NIS (or NO). dhclient_program="/sbin/dhclient" # Path to dhcp client program. dhclient_flags="" # Extra flags to pass to dhcp client. -dhclient_flags_fxp0="" # Extra dhclient flags for fxp0 only +#dhclient_flags_fxp0="" # Extra dhclient flags for fxp0 only background_dhclient="NO" # Start dhcp client in the background. -background_dhclient_fxp0="" # Start dhcp client on fxp0 in the background. +#background_dhclient_fxp0="YES" # Start dhcp client on fxp0 in the background. synchronous_dhclient="YES" # Start dhclient directly on configured # interfaces during startup. firewall_enable="NO" # Set to YES to enable firewall functionality Having pppoed_interface default to fxp0 is also likely a bug. It should probably be unset, and the rc.d script should require it to be set if pppoed is enabled. -- John Baldwin