From owner-svn-src-all@freebsd.org Sun Feb 12 16:24:36 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 27A87CDC438; Sun, 12 Feb 2017 16:24:36 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id C6277106E; Sun, 12 Feb 2017 16:24:35 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from spqr.komquats.com ([96.50.22.10]) by shaw.ca with SMTP id cwwtc13huVQuxcwwucxclj; Sun, 12 Feb 2017 09:24:29 -0700 X-Authority-Analysis: v=2.2 cv=BNTDlBYG c=1 sm=1 tr=0 a=jvE2nwUzI0ECrNeyr98KWA==:117 a=jvE2nwUzI0ECrNeyr98KWA==:17 a=kj9zAlcOel0A:10 a=n2v9WMKugxEA:10 a=bwMe9klDAAAA:8 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=RZfAgueiB8sD2i_sQvcA:9 a=CjuIK1q_8ugA:10 a=JhGllAdGin1EU15OQ7Be:22 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id 533FDA20; Sun, 12 Feb 2017 08:24:27 -0800 (PST) Received: from slippy (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id v1CGOQGr009733; Sun, 12 Feb 2017 08:24:26 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201702121624.v1CGOQGr009733@slippy.cwsent.com> X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.6 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: "George Neville-Neil" cc: "Glen Barber" , "Ermal =?utf-8?q?Lu=C3=A7i?=" , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r313675 - in head/sys: netinet netinet6 In-Reply-To: Message from "George Neville-Neil" of "Sun, 12 Feb 2017 10:41:58 -0500." <53D3A92C-6C64-4C0C-A5E6-B659BFA139BF@neville-neil.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sun, 12 Feb 2017 08:24:26 -0800 X-CMAE-Envelope: MS4wfEl+ruQT3f5zZpwgsnC5faR2Xps9umD6cnHtOKH0yZRhluWo5xsNTrgUm5JnPZi1yeCTEus4nbh4kRg4EEmExEnjvq7HsB9uk5ngONjYzgLnGhueF1tz TOC7g1WRGtNgd5LbvfIoFbJuMru1RML/6S1sH96lfk0Pcx0VfTQ4XZMBNwK6j5jkeJmYHAaePXkq3nSE6hWyoh+k4jHAfm8Tlo3mQcoVZje47C57LpoBPiXz N41JanCtCRfhO2tjOv2EtKAXTj4hfe16shzdGgai4cYjmwFQ+t1dL3g8SmMNl/qDvaWrr2+QPpEZ+hR85ZM4f4Cs/cYpesBt9XyV5ItiGYg= X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Feb 2017 16:24:36 -0000 In message <53D3A92C-6C64-4C0C-A5E6-B659BFA139BF@neville-neil.com>, "George Nev ille-Neil" writes: > This is an OpenPGP/MIME signed message (RFC 3156 and 4880). > > --=_MailMate_399D2B93-4FB8-4736-9FAB-586EA5CE5549_= > Content-Type: text/plain; charset=utf-8; markup=markdown > Content-Transfer-Encoding: quoted-printable > > > > On 12 Feb 2017, at 6:10, Glen Barber wrote: > > > On Sun, Feb 12, 2017 at 06:56:33AM +0000, Ermal Lu=C3=A7i wrote: > >> Author: eri > >> Date: Sun Feb 12 06:56:33 2017 > >> New Revision: 313675 > >> URL: https://svnweb.freebsd.org/changeset/base/313675 > >> > >> Log: > >> Committed without approval from mentor. > >> > >> Reported by: gnn > >> > > > > What exactly does this mean? > > > > Ermal took the Acceptance on reviews.freebsd.org by Adrian as an implicit= > "go ahead" to commit to the tree. The issue is that he's still under me= > ntorship, by me, and had not gotten an approval or had an Approved by: li= > ne. I asked him to revert the change himself. > > We're working out a few more issues in the review now. I didn't read this when I hit send on my email. Hopefully nobody takes offense. I was upset and still am. I still think that the revision numbers of any backout should have been documented in the commit log. Something we could do, as is expected by re@ for commits during a freeze, is metees also let their mentors know of what the contents of commit log messages will be. I think commit log messages discussing the what, why and rationale are as important as the code itself. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.